linux-kernel - Re: [PATCH] regulator: palmas: fix typo in enable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 23 Jun 2014 17:28:30 -0500
From:	Nishanth Menon <nm@...com>
To:	Stephen Warren <swarren@...dotorg.org>,
	Liam Girdwood <lgirdwood@...il.com>,
	Mark Brown <broonie@...nel.org>
CC:	linux-kernel@...r.kernel.org, Stephen Warren <swarren@...dia.com>,
	Alex Courbot <gnurou@...il.com>, Keerthy <j-keerthy@...com>,
	linux-omap@...r.kernel.org, linux-tegra@...r.kernel.org
Subject: Re: [PATCH] regulator: palmas: fix typo in enable_reg calculation

On 06/23/2014 03:53 PM, Stephen Warren wrote:
> From: Stephen Warren <swarren@...dia.com>
>
> When setting up .enable_reg for an SMPS regulator, presumably we should
> call PALMAS_BASE_TO_REG(PALMAS_SMPS_BASE, ...) rather than using
> LDO_BASE. This change makes the LCD panel and HDMI work again on the
> NVIDIA Dalmore board anyway.
>
> Cc: Alex Courbot <gnurou@...il.com>
> Cc: Keerthy <j-keerthy@...com>
> Cc: Nishanth Menon <nm@...com>
> Cc: linux-omap@...r.kernel.org
> Cc: linux-tegra@...r.kernel.org
> Fixes: 318dbb02b50c ("regulator: palmas: Fix SMPS enable/disable/is_enabled")
> Fixes: dbabd624d4eec50b6 ("regulator: palmas: Reemove open coded functions with helper functions")
> Signed-off-by: Stephen Warren <swarren@...dia.com>
> ---
>   drivers/regulator/palmas-regulator.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/regulator/palmas-regulator.c b/drivers/regulator/palmas-regulator.c
> index 3c861d5f9245..93b4ad842901 100644
> --- a/drivers/regulator/palmas-regulator.c
> +++ b/drivers/regulator/palmas-regulator.c
> @@ -970,7 +970,7 @@ static int palmas_regulators_probe(struct platform_device *pdev)
>   					PALMAS_SMPS12_CTRL_MODE_ACTIVE_MASK;
>
>   			pmic->desc[id].enable_reg =
> -					PALMAS_BASE_TO_REG(PALMAS_LDO_BASE,
> +					PALMAS_BASE_TO_REG(PALMAS_SMPS_BASE,
>   						palmas_regs_info[id].ctrl_addr);
>   			pmic->desc[id].enable_mask =
>   					PALMAS_SMPS12_CTRL_MODE_ACTIVE_MASK;
>


Uggh... my bad..

Thanks for catching this.

Acked-by: Nishanth Menon <nm@...com>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/