linux-kernel - [PATCH] ahci: disable ncq feature for hisilicon sata

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 24 Jun 2014 16:56:44 -0400
From:	Tejun Heo <tj@...nel.org>
To:	"kefeng.wang" <kefeng.wang@...aro.org>
Cc:	Hans de Goede <hdegoede@...hat.com>,
	Zhangfei Gao <zhangfei.gao@...aro.org>,
	linux-ide@...r.kernel.org, linux-kernel@...r.kernel.org,
	wangkefeng.wang@...wei.com, xuwei5@...ilicon.com
Subject: [PATCH] ahci: disable ncq feature for hisilicon sata

>From 72cbaa3d2f563d7b48c9f8aef47ec9aa3a31adf2 Mon Sep 17 00:00:00 2001
From: Kefeng Wang <kefeng.wang@...aro.org>
Date: Tue, 24 Jun 2014 16:54:23 -0400

NCQ feature is unsupported on hisilicon sata controller, so disable
it.  This version of IP is used by hip04 and hix5hd2 soc.

tj: "|=" was replaced with "=" for no reason.  Restored "|=".

Signed-off-by: Kefeng Wang <kefeng.wang@...aro.org>
Sigend-off-by: Tejun Heo <tj@...nel.org>
---
Patch didn't apply.  Applied to libata/for-3.16-fixes manually and
dropped "|=" -> "=" conversion.  Why was this done?

Thanks.

 drivers/ata/ahci_platform.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/ata/ahci_platform.c b/drivers/ata/ahci_platform.c
index ebe505c..b10d81d 100644
--- a/drivers/ata/ahci_platform.c
+++ b/drivers/ata/ahci_platform.c
@@ -58,7 +58,7 @@ static int ahci_probe(struct platform_device *pdev)
 	}
 
 	if (of_device_is_compatible(dev->of_node, "hisilicon,hisi-ahci"))
-		hflags |= AHCI_HFLAG_NO_FBS;
+		hflags |= AHCI_HFLAG_NO_FBS | AHCI_HFLAG_NO_NCQ;
 
 	rc = ahci_platform_init_host(pdev, hpriv, &ahci_port_info,
 				     hflags, 0, 0);
-- 
1.9.3

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/