linux-kernel - Re: [PATCH] perf tool: Carve out ctype.h et al

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 25 Jun 2014 21:25:47 +0200
From:	Jiri Olsa <jolsa@...hat.com>
To:	Borislav Petkov <bp@...en8.de>
Cc:	LKML <linux-kernel@...r.kernel.org>,
	Arnaldo Carvalho de Melo <acme@...radead.org>,
	Ingo Molnar <mingo@...nel.org>,
	Peter Zijlstra <peterz@...radead.org>,
	Robert Richter <rric@...nel.org>,
	David Ahern <dsahern@...il.com>,
	Namhyung Kim <namhyung@...il.com>,
	Jean Pihet <jean.pihet@...aro.org>
Subject: Re: [PATCH] perf tool: Carve out ctype.h et al

On Wed, Jun 25, 2014 at 11:23:04AM +0200, Borislav Petkov wrote:
> From: Borislav Petkov <bp@...e.de>
> 
> Carve out ctype.* and util.* stuff into tools/lib/util/. We're keeping
> those as standalone object files in TOOLS_OBJS and add them to the
> targets that need them.
> 
> This way we don't do lib archives but single objects only.

heya,
got following error;

[jolsa@...va perf]$ make
  BUILD:   Doing 'make -j4' parallel build
  CC       util/pmu.o
  CC       util/parse-events-flex.o
  SUBDIR   /home/jolsa/kernel.org/linux-perf/tools/lib/traceevent/
util/pmu.c: In function ‘wordwrap’:
util/pmu.c:788:3: error: implicit declaration of function ‘isspace’ [-Werror=implicit-function-declaration]
   while (isspace(*s))
   ^
cc1: all warnings being treated as errors
make[1]: *** [util/pmu.o] Error 1
make[1]: *** Waiting for unfinished jobs....
make: *** [all] Error 2

Anyway, so you moved hex2u64, ctype interface under tools/lib
and made several Makefile changes to compile tools/lib objects.

Besides that we'd need all those changes separated, who is the
other user of this library? I dont see any in the patch.

thanks,
jirka
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/