linux-kernel - Re: [PATCH] ARM: DRA7-evm: Enable SATA PHY and USB PHY power supplies

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 26 Jun 2014 12:36:45 +0300
From:	Roger Quadros <rogerq@...com>
To:	Tony Lindgren <tony@...mide.com>, Nishanth Menon <nm@...com>
CC:	<rnayak@...com>, <balbi@...com>, <nsekhar@...com>, <kishon@...com>,
	<george.cherian@...com>, <linux-omap@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] ARM: DRA7-evm: Enable SATA PHY and USB PHY power supplies

On 06/26/2014 10:31 AM, Tony Lindgren wrote:
> * Nishanth Menon <nm@...com> [140625 15:29]:
>> On 06/25/2014 07:56 AM, Roger Quadros wrote:
>>> The SATA and USB PHYs need the 1.8V and 3.3V supplies.
>>> The PHY drivers/framework don't yet support regulator
>>> supply so we have to keep these regulators always-on till
>>> then.
>>>
>>> Signed-off-by: Roger Quadros <rogerq@...com>
>>> ---
>>>  arch/arm/boot/dts/dra7-evm.dts | 2 ++
>>>  1 file changed, 2 insertions(+)
>>>
>>> diff --git a/arch/arm/boot/dts/dra7-evm.dts b/arch/arm/boot/dts/dra7-evm.dts
>>> index 4adc280..99a1f79 100644
>>> --- a/arch/arm/boot/dts/dra7-evm.dts
>>> +++ b/arch/arm/boot/dts/dra7-evm.dts
>>> @@ -241,6 +241,7 @@
>>>  					regulator-min-microvolt = <1800000>;
>>>  					regulator-max-microvolt = <1800000>;
>>>  					regulator-boot-on;
>>> +					regulator-always-on;
>>>  				};
>>>  
>>>  				ldo9_reg: ldo9 {
>>> @@ -266,6 +267,7 @@
>>>  					regulator-min-microvolt = <3300000>;
>>>  					regulator-max-microvolt = <3300000>;
>>>  					regulator-boot-on;
>>> +					regulator-always-on;
>>>  				};
>>>  			};
>>>  		};
>>>
>>
>> Why not fix phy driver/framework as needed? the trouble is people
>> always forget to remove always-on... who actually audits old logs and
>> fixes stuff back up?
> 
> Yes I agree let's not play with the regulator-always-on unless
> absolutely necessary.
> 
Agreed. PHY framework must deal with this. Till then USB, SATA and most likely PCIe as well will not work on DRA7-evm.

cheers,
-roger

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/