lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 26 Jun 2014 10:28:39 +0530 From: Naveen Krishna Ch <naveenkrishna.ch@...il.com> To: Sachin Kamat <spk.linux@...il.com> Cc: Naveen Krishna Chatradhi <ch.naveen@...sung.com>, linux-samsung-soc <linux-samsung-soc@...r.kernel.org>, linux-i2c@...r.kernel.org, "linux-arm-kernel@...ts.infradead.org" <linux-arm-kernel@...ts.infradead.org>, sjg@...omium.org, open list <linux-kernel@...r.kernel.org>, Wolfram Sang <wsa@...-dreams.de>, cpgs@...sung.com, broonie@...nel.org Subject: Re: [PATCH 2/2] i2c: exynos5: fix minor styling nits Hello Sachin, On 25 June 2014 16:19, Sachin Kamat <spk.linux@...il.com> wrote: > Hi Naveen, > > On Wed, Jun 25, 2014 at 4:08 PM, Naveen Krishna Chatradhi > <ch.naveen@...sung.com> wrote: >> This patch removes an extra line and fixes a styling nit >> in exynos5_i2c_message_start() >> >> Signed-off-by: Naveen Krishna Chatradhi <ch.naveen@...sung.com> >> --- >> drivers/i2c/busses/i2c-exynos5.c | 3 +-- >> 1 file changed, 1 insertion(+), 2 deletions(-) >> >> diff --git a/drivers/i2c/busses/i2c-exynos5.c b/drivers/i2c/busses/i2c-exynos5.c >> index 0d1a7bc..4c2e6f3 100644 >> --- a/drivers/i2c/busses/i2c-exynos5.c >> +++ b/drivers/i2c/busses/i2c-exynos5.c >> @@ -525,7 +525,7 @@ static void exynos5_i2c_message_start(struct exynos5_i2c *i2c, int stop) >> if (i2c->msg->flags & I2C_M_RD) { >> i2c_ctl |= HSI2C_RXCHON; >> >> - i2c_auto_conf = HSI2C_READ_WRITE; >> + i2c_auto_conf |= HSI2C_READ_WRITE; > > This change looks more than just a styling nit. Please update the commit message > accordingly. Yea, change looks so. But, This is not an going to change the way code works. As, i2c_auto_conf is initialized to '0' at the beginning of the function and HSI2C_READ_WRITE is defined as (1u << 16) This being the 1st usage, I thought using "|=" is better way of assignment. Will edit the commit message accordingly. > > -- > Regards, > Sachin. Thanks, -- Shine bright, (: Nav :) -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists