linux-kernel - Re: [PATCH 1/1] drivers/power/avs/smartreflex.c: remove unnecessary null test before debugfs_remove

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sat, 28 Jun 2014 08:36:23 -0500
From:	Nishanth Menon <nm@...com>
To:	Fabian Frederick <fabf@...net.be>, linux-kernel@...r.kernel.org
CC:	Kevin Hilman <khilman@...nel.org>, linux-pm@...r.kernel.org,
	linux-omap <linux-omap@...r.kernel.org>
Subject: Re: [PATCH 1/1] drivers/power/avs/smartreflex.c: remove unnecessary
 null test before debugfs_remove_recursive

Minor fix of $subject to be inline with existing logs needed.
PM / AVS: SmartReflex: ..

On 06/28/2014 07:33 AM, Fabian Frederick wrote:
> Fix checkpatch warning:
> WARNING: debugfs_remove_recursive(NULL) is safe this check is probably not required
>
> Cc: Kevin Hilman <khilman@...nel.org>
> Cc: Nishanth Menon <nm@...com>
> Cc: linux-pm@...r.kernel.org
> Signed-off-by: Fabian Frederick <fabf@...net.be>
> ---
>   drivers/power/avs/smartreflex.c | 3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/power/avs/smartreflex.c b/drivers/power/avs/smartreflex.c
> index db9973b..ecc5979 100644
> --- a/drivers/power/avs/smartreflex.c
> +++ b/drivers/power/avs/smartreflex.c
> @@ -1001,8 +1001,7 @@ static int omap_sr_remove(struct platform_device *pdev)
>
>   	if (sr_info->autocomp_active)
>   		sr_stop_vddautocomp(sr_info);
> -	if (sr_info->dbg_dir)
> -		debugfs_remove_recursive(sr_info->dbg_dir);
> +	debugfs_remove_recursive(sr_info->dbg_dir);
>
>   	pm_runtime_disable(&pdev->dev);
>   	list_del(&sr_info->node);
>
Acked-by: Nishanth Menon <nm@...com>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/