linux-kernel - RE: [PATCH 1/1] iommu/fsl_pamu: Remove unnecessary null test before kfree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 29 Jun 2014 11:17:19 +0000
From:	Varun Sethi <Varun.Sethi@...escale.com>
To:	Fabian Frederick <fabf@...net.be>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
CC:	Grant Likely <grant.likely@...aro.org>,
	"iommu@...ts.linux-foundation.org" <iommu@...ts.linux-foundation.org>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>
Subject: RE: [PATCH 1/1] iommu/fsl_pamu: Remove unnecessary null test before
 kfree



> -----Original Message-----
> From: iommu-bounces@...ts.linux-foundation.org [mailto:iommu-
> bounces@...ts.linux-foundation.org] On Behalf Of Fabian Frederick
> Sent: Sunday, June 29, 2014 1:31 PM
> To: linux-kernel@...r.kernel.org
> Cc: Fabian Frederick; Grant Likely; iommu@...ts.linux-foundation.org;
> devicetree@...r.kernel.org
> Subject: [PATCH 1/1] iommu/fsl_pamu: Remove unnecessary null test before
> kfree
> 
> Fix checkpatch warning:
> WARNING: kfree(NULL) is safe this check is probably not required
> 
> Cc: Joerg Roedel <joro@...tes.org>
> Cc: Grant Likely <grant.likely@...aro.org>
> Cc: iommu@...ts.linux-foundation.org
> Cc: devicetree@...r.kernel.org
> Signed-off-by: Fabian Frederick <fabf@...net.be>
> ---
>  drivers/iommu/fsl_pamu_domain.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/iommu/fsl_pamu_domain.c
> b/drivers/iommu/fsl_pamu_domain.c index 93072ba..0009dff 100644
> --- a/drivers/iommu/fsl_pamu_domain.c
> +++ b/drivers/iommu/fsl_pamu_domain.c
> @@ -1118,8 +1118,7 @@ static int fsl_pamu_set_windows(struct iommu_domain
> *domain, u32 w_count)
>  	ret = pamu_set_domain_geometry(dma_domain, &domain->geometry,
>  				((w_count > 1) ? w_count : 0));
>  	if (!ret) {
> -		if (dma_domain->win_arr)
> -			kfree(dma_domain->win_arr);
> +		kfree(dma_domain->win_arr);
>  		dma_domain->win_arr = kzalloc(sizeof(struct dma_window) *
>  							  w_count, GFP_ATOMIC);
>  		if (!dma_domain->win_arr) {

Acked-by: Varun Sethi <varun.sethi@...escale.com>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/