linux-kernel - Re: [PATCH] arch/score/include/uapi/asm/ptrace.h: Add prefix 'SCORE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:	Mon, 30 Jun 2014 09:42:42 +0800
From:	Chen Gang <gang.chen.5i5j@...il.com>
To:	Guenter Roeck <linux@...ck-us.net>,
	Liqin Chen <liqin.linux@...il.com>,
	Lennox Wu <lennox.wu@...il.com>
CC:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	David Rientjes <rientjes@...gle.com>
Subject: Re: [PATCH] arch/score/include/uapi/asm/ptrace.h: Add prefix 'SCORE_'
 for related macros

On 06/27/2014 06:12 PM, Chen Gang wrote:
> On 06/25/2014 08:28 AM, Chen Gang wrote:
>> On 06/24/2014 10:44 PM, Guenter Roeck wrote:
>>> On 06/24/2014 06:24 AM, Chen Gang wrote:
>>>> On 06/23/2014 11:03 AM, Chen Gang wrote:
>>>>> On 06/22/2014 11:02 PM, Guenter Roeck wrote:
>>>>>> On 06/22/2014 07:53 AM, Guenter Roeck wrote:
>>>>>>> I did that, and managed to build gcc.
>>>>>>>
>>>>>>> However, when trying to compile score defconfig, I get internal
>>>>>>> compiler errors in cc1
>>>>>>> when compiling drivers/tty/tty_mutex.o and block/elevator.o.
>>>>>>>
>>>>>>>    CC      block/elevator.o
>>>>>>> score-elf-gcc: internal compiler error: Segmentation fault (program
>>>>>>> cc1)
>>>>>>> 0x40c073 execute
>>>>>>>       ../../gcc/gcc/gcc.c:2848
>>>>>>> Please submit a full bug report,
>>>>>>> with preprocessed source if appropriate.
>>>>>>> Please include the complete backtrace with any bug report.
>>>>>>> See <http://gcc.gnu.org/bugs.html> for instructions.
>>>>>>> make[1]: *** [block/elevator.o] Error 4
>>>>>>> make: *** [block/elevator.o] Error 2
>>>>>>>
>>>>>>> Do you see that as well ?
>>>>>>>
>>>>>>> This is with
>>>>>>>
>>>>>>> GNU assembler version 2.24.51 (score-elf) using BFD version (GNU
>>>>>>> Binutils) 2.24.51.20140622
>>>>>>>
>>>>>>> and gcc configured with:
>>>>>>>
>>>>>>> Configured with: ../gcc/configure --prefix=/opt/kernel/score
>>>>>>> --program-prefix=score-elf- \
>>>>>>> --target=score-elf --without-header --disable-nls --enable-languages=c
>>>>>>> --disable-threads \
>>>>>>> --disable-shared --enable-werror=no
>>>>>>> target_configargs=enable_vtable_verify=yes \
>>>>>>> --enable-obsolete --disable-libssp --disable-libquadmath
>>>>>>>
>>>>>>> Tip of gcc source is commit d8686b0aa945a, tip of binutils source is
>>>>>>> commit d17c74c1d41.
>>>>>>> Your assembler fix is included in this version of binutils.
>>>>>>>
>>>>
>>>> Can we repeated this issue, or it is random?  I have try it use my
>>>> current gcc version, it has no issue.
>>>>
>>>> If it can be repeated in the latest version, I shall use version compine
>>>> (and try step by step) to fix it.
>>>>
>>>> If real random issue, if possible, please help repeated and generate
>>>> coredump file, and put it to a place to let me get back for analysing.
>>>>
>>> I got the same error each time. You should be able to reproduce it by
>>> checking out the latest gcc. If that doesn't produce the error, try
>>> checking out sha d8686b0aa945a. I didn't keep that compiler after the tip
>>> of the gcc 4.9 branch worked, so I'd have to rebuild it myself
>>> to reproduce it myself.
>>>
>>> Note that compilation of libssp failed with d8686b0aa945a, which is why
>>> I disabled it. I didn't try to build it with 4.9.
>>>

gcc members response quickly, and confirm it, the related fix patch
which is made by a gcc member and I, have applied into latest gcc source
code.

So... I finished it within this month (this thread will be end)!  :-)


Thanks.
> 
> And I guess, I have found the root cause, and sent related information
> to gcc mailing list (also cc to you). And one temporary fix below (can
> cross compile score defconfig successfully for latest gcc):
> 
>   diff --git a/gcc/c/c-decl.c b/gcc/c/c-decl.c
>   index def10a2..af49601 100644
>   --- a/gcc/c/c-decl.c
>   +++ b/gcc/c/c-decl.c
>   @@ -2300,15 +2300,6 @@ merge_decls (tree newdecl, tree olddecl, tree newtype, tree oldtype)
>    
>      if (CODE_CONTAINS_STRUCT (TREE_CODE (olddecl), TS_DECL_WITH_VIS))
>        {
>   -      /* Merge the section attribute.
>   -	 We want to issue an error if the sections conflict but that
>   -	 must be done later in decl_attributes since we are called
>   -	 before attributes are assigned.  */
>   -      if ((DECL_EXTERNAL (olddecl) || TREE_PUBLIC (olddecl) || TREE_STATIC (olddecl))
>   -	  && DECL_SECTION_NAME (newdecl) == NULL
>   -	  && DECL_SECTION_NAME (olddecl))
>   -	set_decl_section_name (newdecl, DECL_SECTION_NAME (olddecl));
>   -
>          /* Copy the assembler name.
>    	 Currently, it can only be defined in the prototype.  */
>          COPY_DECL_ASSEMBLER_NAME (olddecl, newdecl);
> 
> I shall continue for it, and provide the final property fix for it.
> 
> Thanks.
> 
>>
>> Thank you very much for your work.
>>
>> It is my chance to fix gcc issues which I have planed, I shall continue
>> based on it, hope I can finish within this month (within 2014-06-30).
>>
>>
>> Thanks.
>>
> 

-- 
Chen Gang

Open, share, and attitude like air, water, and life which God blessed
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/