| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Mon, 30 Jun 2014 16:38:04 +0200 (CEST) From: Jiri Kosina <jkosina@...e.cz> To: Nicholas Krause <xerofoify@...il.com> cc: linux-input@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH] Fixes kernel panic with Null pointer in hid-appleir.c On Fri, 20 Jun 2014, Nicholas Krause wrote: > In for loop of function appleir_input_configured we hit > a Null pointer after the for loop due to array_size not > being correct needs to be changed to input_dev->keycodemax. > > Signed-off-by: Nicholas Krause <xerofoify@...il.com> > --- > drivers/hid/hid-appleir.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/hid/hid-appleir.c b/drivers/hid/hid-appleir.c > index 0e6a42d..ab0a702 100644 > --- a/drivers/hid/hid-appleir.c > +++ b/drivers/hid/hid-appleir.c > @@ -272,7 +272,7 @@ static void appleir_input_configured(struct hid_device *hid, > input_dev->evbit[0] = BIT(EV_KEY) | BIT(EV_REP); > > memcpy(appleir->keymap, appleir_key_table, sizeof(appleir->keymap)); > - for (i = 0; i < ARRAY_SIZE(appleir_key_table); i++) > + for (i = 0; i < ARRAY_SIZE(input_dev->keycodemax); i++) Ugh, how is this supposed to work? input_dev->keycodemax is int, not array. I think you actually want sizeof(appleir->keymap) there. -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists