linux-kernel - Re: [PATCH 05/18] perf tools: Add ordered_events

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 30 Jun 2014 12:03:59 -0300
From:	Arnaldo Carvalho de Melo <acme@...nel.org>
To:	Jiri Olsa <jolsa@...hat.com>
Cc:	David Ahern <dsahern@...il.com>, Jiri Olsa <jolsa@...nel.org>,
	linux-kernel@...r.kernel.org,
	Corey Ashford <cjashfor@...ux.vnet.ibm.com>,
	Frederic Weisbecker <fweisbec@...il.com>,
	Ingo Molnar <mingo@...nel.org>,
	Jean Pihet <jean.pihet@...aro.org>,
	Namhyung Kim <namhyung@...nel.org>,
	Paul Mackerras <paulus@...ba.org>,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>
Subject: Re: [PATCH 05/18] perf tools: Add ordered_events_(get|put) interface

Em Sun, Jun 29, 2014 at 06:39:33PM +0200, Jiri Olsa escreveu:
> On Fri, Jun 27, 2014 at 05:06:36PM -0600, David Ahern wrote:
> > On 6/18/14, 8:58 AM, Jiri Olsa wrote:
> > >+static struct ordered_event*
> > >+ordered_events_get(struct ordered_events_queue *q, u64 timestamp)

Also I don't think that it matters that much to have explicit in the
name above the data structure used to reorder events, i.e. I suggest
renaming "struct ordered_events_queue" to just "struct ordered_events".

- Arnaldo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/