linux-kernel - Re: [PATCH resend v2 1/3] mfd-core: Don't register supplies from add_device, add register_supply

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 1 Jul 2014 15:14:50 +0100
From:	Lee Jones <lee.jones@...aro.org>
To:	Hans de Goede <hdegoede@...hat.com>
Cc:	Mark Brown <broonie@...aro.org>,
	Charles Keepax <ckeepax@...nsource.wolfsonmicro.com>,
	Samuel Ortiz <sameo@...ux.intel.com>,
	Liam Girdwood <lgirdwood@...il.com>,
	Carlo Caione <carlo@...one.org>,
	Maxime Ripard <maxime.ripard@...e-electrons.com>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	linux-sunxi@...glegroups.com
Subject: Re: [PATCH resend v2 1/3] mfd-core: Don't register supplies from
 add_device, add register_supply_aliases()

On Tue, 01 Jul 2014, Hans de Goede wrote:
> On 07/01/2014 11:22 AM, Lee Jones wrote:
> > On Mon, 30 Jun 2014, Hans de Goede wrote:
> > 
> >> We cannot register supply alias in mfd_add_device before calling
> >> platform_add_device because platform-dev's name must be set before registering
> >> the aliases which happens from platform_add_device.
> >>
> >> So stop registering supply aliases from mfd_add_device, and add a
> >> mfd_register_supply_aliases helper functions for the cell's plaform driver
> >> probe method to use.
> >>
> >> Signed-off-by: Hans de Goede <hdegoede@...hat.com>
> > 
> > Didn't I already Ack this?
> 
> Ah yes you did, but back then I expected the series to get picked up
> immediately, so I did not add the ack to my local copy of it.

When resubmitting, it's always a good idea to look at previous review
in order to search for review comments to fix, or Acks to apply.
Unfortunately the set couldn't go in without Mark's review - which is
still the case.

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/