linux-kernel - usb: gadget: net2280: CONFIG_USB_GADGET_PDEBUG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 04 Jul 2014 09:37:57 +0200
From:	Paul Bolle <pebolle@...cali.nl>
To:	Ricardo Ribalda Delgado <ricardo.ribalda@...il.com>,
	Felipe Balbi <balbi@...com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:	linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: usb: gadget: net2280: CONFIG_USB_GADGET_PDEBUG_FILES?

Commit e56e69cc0ff4 ("usb: gadget: net2280: Use pr_* function") is
included in today's linux-next (ie, next-20140704).

It contains this odd chunk:
    @@ -1566,7 +1563,7 @@ static const struct usb_gadget_ops net2280_ops = {
     
     /*-------------------------------------------------------------------------*/
     
    -#ifdef CONFIG_USB_GADGET_DEBUG_FILES
    +#ifdef CONFIG_USB_GADGET_PDEBUG_FILES
     
     /* FIXME move these into procfs, and use seq_file.
      * Sysfs _still_ doesn't behave for arbitrarily sized files,

(Commit b7ca96655ddd ("usb: gadget: Gadget directory cleanup - group UDC
drivers"), also included in today's linux-next, moved that new check for
CONFIG_USB_GADGET_PDEBUG_FILES to drivers/usb/gadget/udc/net2280.c.)

Using CONFIG_USB_GADGET_PDEBUG_FILES appears to be just an editing
mistake. Would Ricardo like to submit the trivial patch to clean it up
or should I do that?


Paul Bolle

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/