linux-kernel - [PATCH 1/1] staging: cxt1e1: remove null test before kfree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Fri,  4 Jul 2014 21:58:15 +0200
From:	Fabian Frederick <fabf@...net.be>
To:	linux-kernel@...r.kernel.org
Cc:	Fabian Frederick <fabf@...net.be>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Daeseok Youn <daeseok.youn@...il.com>,
	devel@...verdev.osuosl.org
Subject: [PATCH 1/1] staging: cxt1e1: remove null test before kfree

Fix checkpatch warning:
WARNING: kfree(NULL) is safe this check is probably not required

Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc: Daeseok Youn <daeseok.youn@...il.com>
Cc: devel@...verdev.osuosl.org
Signed-off-by: Fabian Frederick <fabf@...net.be>
---
 drivers/staging/cxt1e1/pmcc4_drv.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/drivers/staging/cxt1e1/pmcc4_drv.c b/drivers/staging/cxt1e1/pmcc4_drv.c
index 76bebdd..e738264 100644
--- a/drivers/staging/cxt1e1/pmcc4_drv.c
+++ b/drivers/staging/cxt1e1/pmcc4_drv.c
@@ -454,10 +454,7 @@ c4_cleanup (void)
             pi = &ci->port[portnum];
             c4_wq_port_cleanup (pi);
             for (j = 0; j < MUSYCC_NCHANS; j++)
-            {
-                if (pi->chan[j])
-                    kfree(pi->chan[j]);     /* free mch_t struct */
-            }
+                kfree(pi->chan[j]);     /* free mch_t struct */
             kfree(pi->regram_saved);
         }
         kfree(ci->iqd_p_saved);
-- 
1.9.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/