[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Sun, 6 Jul 2014 17:22:00 +0200
From: Arnd Bergmann <arnd@...db.de>
To: Maxime Ripard <maxime.ripard@...e-electrons.com>
Cc: Mark Rutland <mark.rutland@....com>,
Dan Williams <dan.j.williams@...el.com>,
Vinod Koul <vinod.koul@...el.com>,
"andriy.shevchenko@...el.com" <andriy.shevchenko@...el.com>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
"zhuzhenhua@...winnertech.com" <zhuzhenhua@...winnertech.com>,
"dmaengine@...r.kernel.org" <dmaengine@...r.kernel.org>,
"linux-sunxi@...glegroups.com" <linux-sunxi@...glegroups.com>,
"kevin.z.m.zh@...il.com" <kevin.z.m.zh@...il.com>,
"sunny@...winnertech.com" <sunny@...winnertech.com>,
"shuge@...winnertech.com" <shuge@...winnertech.com>,
"linux-arm-kernel@...ts.infradead.org"
<linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH v10 2/2] dmaengine: sun6i: Add driver for the Allwinner A31 DMA controller
On Friday 04 July 2014, Maxime Ripard wrote:
> > > > It feels a little fragile to rely on the organisation of the clock tree
> > > > and the naming thereof. If the IP block is ever reused on an SoC with a
> > > > different clock tree layout then we have to handle things differently.
> > >
> > > What do you suggest then?
> >
> > I will admit that I don't have a better suggestion.
> >
> > Without knowing which particular constraint on the mux parent clock we
> > care about it's difficult to suggest anything useful.
>
> Well, I first made it into the mach- directory, and then was told to
> move it in the driver itself, so we're kind of running out of options
> :)
How about having a property in the clock provider node that forces a
specific value for the mux? I think that's generally the preferred solution
for any clock settings that go beyond what an OS can be expected to figure
out for itself.
Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists