[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Mon, 7 Jul 2014 10:24:35 -0500 (CDT)
From: Christoph Lameter <cl@...two.org>
To: Vladimir Davydov <vdavydov@...allels.com>
cc: akpm@...ux-foundation.org, mhocko@...e.cz, hannes@...xchg.org,
glommer@...il.com, linux-mm@...ck.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH -mm 2/8] memcg: keep all children of each root cache on
a list
On Mon, 7 Jul 2014, Vladimir Davydov wrote:
> diff --git a/mm/slab_common.c b/mm/slab_common.c
> index d31c4bacc6a2..95a8f772b0d1 100644
> --- a/mm/slab_common.c
> +++ b/mm/slab_common.c
> @@ -294,8 +294,12 @@ struct kmem_cache *memcg_create_kmem_cache(struct mem_cgroup *memcg,
> if (IS_ERR(s)) {
> kfree(cache_name);
> s = NULL;
> + goto out_unlock;
> }
>
> + list_add(&s->memcg_params->siblings,
> + &root_cache->memcg_params->children);
> +
> out_unlock:
> mutex_unlock(&slab_mutex);
>
If there is an error then s is set to NULL. And then
the list_add is done dereferencing s?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists