[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date: Mon, 7 Jul 2014 15:07:57 -0700
From: Andrew Morton <akpm@...ux-foundation.org>
To: Davidlohr Bueso <davidlohr@...com>
Cc: linux-kernel@...r.kernel.org, linux-mm@...ck.org
Subject: Re: [PATCH] mm,vmacache: inline vmacache_valid_mm()
On Fri, 04 Jul 2014 14:08:03 -0700 Davidlohr Bueso <davidlohr@...com> wrote:
> From: Davidlohr Bueso <davidlohr@...com>
>
> No brainer for this little function.
>
> ...
>
> --- a/mm/vmacache.c
> +++ b/mm/vmacache.c
> @@ -50,7 +50,7 @@ void vmacache_flush_all(struct mm_struct *mm)
> * Also handle the case where a kernel thread has adopted this mm via use_mm().
> * That kernel thread's vmacache is not applicable to this mm.
> */
> -static bool vmacache_valid_mm(struct mm_struct *mm)
> +static inline bool vmacache_valid_mm(struct mm_struct *mm)
> {
> return current->mm == mm && !(current->flags & PF_KTHREAD);
> }
The patch doesn't actually do anything.
- gcc ignores `inline'
- gcc will inline this function anwyay
- if we really really need a hammer, we use __always_inline, along
with a comment explaining why.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists