[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Tue, 8 Jul 2014 07:14:01 +0800
From: Wanpeng Li <wanpeng.li@...ux.intel.com>
To: Bandan Das <bsd@...hat.com>
Cc: Paolo Bonzini <pbonzini@...hat.com>,
Jan Kiszka <jan.kiszka@...mens.com>,
Gleb Natapov <gleb@...nel.org>,
Hu Robert <robert.hu@...el.com>, kvm@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH] KVM: nVMX: Fix IRQs inject to L2 which belong to L1
since race
On Mon, Jul 07, 2014 at 01:38:37PM -0400, Bandan Das wrote:
>Paolo Bonzini <pbonzini@...hat.com> writes:
>
>> Il 07/07/2014 19:31, Bandan Das ha scritto:
>>>> >
>>>> > Which patch? Yours or Bandan's?
>>> Why don't we hold off on Wanpeng's patch and instead apply the one I proposed
>>> to call check_nested_events() when checking for interrupt in inject_pending_event() ?
>>
>> Exactly, yours seemed better to apply as a quick regression fix.
>>
>> Can you post it as a toplevel patch, so that the commit message
>> explains what's happening? Perhaps add a comment in the code as well.
>
>Ok, will do, thanks!
As Jan metioned in http://www.spinics.net/lists/kvm/msg105238.html, "In any case,
unconditionally setting KVM_REQ_EVENT seems strange and should be changed." Your
trick still keep the unconditionally setting KVM_REQ_EVENT which is the root cause
of the race there, anyway, I focus on fix the hang currently and a patch will be
submitted soon.
Regards,
Wanpeng Li
>
>> Paolo
>>
>>> I think that will take care of https://bugzilla.kernel.org/show_bug.cgi?id=72381
>>> too. Once, we figure out what's causing hangs under certain conditions with his
>>> patch, we can apply that and revert this change.
>>>
>>>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists