[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Mon, 7 Jul 2014 01:52:33 +0100
From: Grant Likely <grant.likely@...aro.org>
To: Linus Torvalds <torvalds@...ux-foundation.org>
Cc: Rob Herring <rob.herring@...aro.org>,
Laura Abbott <lauraa@...eaurora.org>,
"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [GIT PULL] bug fix for devicetree memory parsing
On Sun, Jul 6, 2014 at 8:24 PM, Linus Torvalds
<torvalds@...ux-foundation.org> wrote:
> On Sun, Jul 6, 2014 at 2:37 AM, Grant Likely <grant.likely@...aro.org> wrote:
>>
>> Can you pull this bug fix into your tree please?
>
> I took it, but I think both your explanation and the patch itself is
> actually crap. It may fix the issue, but it's seriously confused.
>
> Your explanation says that it's a 32-bit platform issue. No it's not.
> Most 32-bit configurations still have a 64-bit phys_addr_t (ie
> PAE/LPAE etc).
>
> And the code is crap, because it uses ULONG_MAX etc in ways that
> simply make no f*cking sense. And why does it care about sizeof?
>
> Why does the code not just do something like
>
> #define MAX_PHYS_ADDR ((phys_addr_t) ~0)
>
> and then do
>
> if (base > MAX_PHYS_ADDR || base + size > MAX_PHYS_ADDR)
> ...
Sure. I'll make sure a cleanup patch gets written and queued up.
g.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists