linux-kernel - Fwd: [PATCH] Fix comments in rbtree.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 8 Jul 2014 12:29:03 -0400
From:	Nick Krause <xerofoify@...il.com>
To:	Guenter Roeck <linux@...ck-us.net>, cody@...ux.vnet.ibm.com
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	sjenning@...ux.vnet.ibm.com,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Fwd: [PATCH] Fix comments in rbtree.c

From: Guenter Roeck  wrote on Mon, Jun 16, 2014 at 11:59 PM
Subject: Re: [PATCH] Fix comments in rbtree.c
To: Nick <xerofoify@...il.com>, cody@...ux.vnet.ibm.com
Cc: akpm@...ux-foundation.org, sjenning@...ux.vnet.ibm.com,
linux-kernel@...r.kernel.org


On 06/14/2014 11:34 AM, Nick wrote:
>
> Signed-off-by: Nick <xerofoify@...il.com>
> ---
>   lib/rbtree.c | 3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/lib/rbtree.c b/lib/rbtree.c
> index 65f4eff..c66370c 100644
> --- a/lib/rbtree.c
> +++ b/lib/rbtree.c
> @@ -101,11 +101,10 @@ __rb_insert(struct rb_node *node, struct rb_root *root,
>                                  *      / \          / \
>                                  *     p   u  -->   P   U
>                                  *    /            /
> -                                *   n            N
> +                                *   n            n


You'll need a lengthy explanation here. What makes you think that the comment
is wrong ?

Guenter


This seems right as  of rereading my patch I sent to you. You can drop
this patch.
Cheers Nick
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/