linux-kernel - RE: [PATCH 1/8] Drivers: scsi: storvsc: Change the limits to reflect the values on the host

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 9 Jul 2014 23:39:42 +0000
From:	KY Srinivasan <kys@...rosoft.com>
To:	KY Srinivasan <kys@...rosoft.com>,
	Christoph Hellwig <hch@...radead.org>
CC:	"linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>,
	"jasowang@...hat.com" <jasowang@...hat.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"jbottomley@...allels.com" <jbottomley@...allels.com>,
	"ohering@...e.com" <ohering@...e.com>,
	"stable@...r.kernel.org" <stable@...r.kernel.org>,
	"apw@...onical.com" <apw@...onical.com>,
	"devel@...uxdriverproject.org" <devel@...uxdriverproject.org>
Subject: RE: [PATCH 1/8] Drivers: scsi: storvsc: Change the limits to reflect
 the values on the host



> -----Original Message-----
> From: driverdev-devel-bounces@...uxdriverproject.org [mailto:driverdev-
> devel-bounces@...uxdriverproject.org] On Behalf Of KY Srinivasan
> Sent: Wednesday, July 9, 2014 1:07 PM
> To: Christoph Hellwig
> Cc: linux-scsi@...r.kernel.org; jasowang@...hat.com; linux-
> kernel@...r.kernel.org; jbottomley@...allels.com; ohering@...e.com;
> stable@...r.kernel.org; apw@...onical.com; devel@...uxdriverproject.org
> Subject: RE: [PATCH 1/8] Drivers: scsi: storvsc: Change the limits to reflect the
> values on the host
> 
> 
> 
> > -----Original Message-----
> > From: Christoph Hellwig [mailto:hch@...radead.org]
> > Sent: Wednesday, July 9, 2014 1:40 AM
> > To: KY Srinivasan
> > Cc: linux-kernel@...r.kernel.org; devel@...uxdriverproject.org;
> > ohering@...e.com; jbottomley@...allels.com; jasowang@...hat.com;
> > apw@...onical.com; linux-scsi@...r.kernel.org; stable@...r.kernel.org
> > Subject: Re: [PATCH 1/8] Drivers: scsi: storvsc: Change the limits to
> > reflect the values on the host
> >
> > On Tue, Jul 08, 2014 at 05:46:45PM -0700, K. Y. Srinivasan wrote:
> > > + * In Hyper-V, each port/path/target maps to 1 scsi host adapter.
> >
> > Does it still?  The STORVSC_FC_MAX_TARGETS define suggests otherwise.
> 
> I will fix the comments and get rid of unnecessary comments.
> 
> >
> > > -	.cmd_per_lun =		1,
> > > +	.cmd_per_lun =		255,
> >
> > This looks like an unrelated change.
> 
> I will have a separate patch for this.
> >
> > > +		/* max # of devices per target */
> > > +		host->max_lun = STORVSC_FC_MAX_LUNS_PER_TARGET;
> > > +		/* max # of targets per channel */
> > > +		host->max_id = STORVSC_FC_MAX_TARGETS;
> > > +		/* max # of channels */
> > > +		host->max_channel = STORVSC_FC_MAX_CHANNELS - 1;
> >
> > I don't think these comments add any value..
> 
> I will get rid of the comments.
> 
> >
> > Also any reason you use off by one defines for max_channel, but not
> > the others?
> 
> No particular reason; I will clean this up.

On further examination max_channel is the maximum number of channels including channel 0. Thus the value set for
max_channel is correct. max_id appears to indicate the limit. In scsi_scan_channel the loop control  is (id < max_id) and
hence the value I have here is correct. max_lun is also used like max_id to indicate the limit. In scsi_sequential_lun_scan()
the loop control is (lun < max_dev_lun) and hence I think the value I have here is fine.

Regards,

K. Y 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/