linux-kernel - Re: [PATCH 8/8] staging: rtl8712: remove inapplicable comment

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 9 Jul 2014 13:01:22 -0400
From:	"James A. Shackleford" <shack@...ux.com>
To:	Dan Carpenter <dan.carpenter@...cle.com>
Cc:	gregkh@...uxfoundation.org, Larry.Finger@...inger.net,
	florian.c.schilhabel@...glemail.com, devel@...verdev.osuosl.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 8/8] staging: rtl8712: remove inapplicable comment

On Tue, Jul 08, 2014 at 01:16:53PM +0300, Dan Carpenter wrote:
> On Tue, Jun 24, 2014 at 10:52:41PM -0400, James A Shackleford wrote:
> > Signed-off-by: James A Shackleford <shack@...ux.com>
> > ---
> >  drivers/staging/rtl8712/osdep_service.h |    5 -----
> >  1 file changed, 5 deletions(-)
> > 
> > diff --git a/drivers/staging/rtl8712/osdep_service.h b/drivers/staging/rtl8712/osdep_service.h
> > index 77b1443..3dfc473 100644
> > --- a/drivers/staging/rtl8712/osdep_service.h
> > +++ b/drivers/staging/rtl8712/osdep_service.h
> > @@ -95,11 +95,6 @@ static inline void _set_workitem(_workitem *pwork)
> >  	#define BIT(x)	(1 << (x))
> >  #endif
> >  
> > -/*
> > -For the following list_xxx operations,
> > -caller must guarantee the atomic context.
> > -Otherwise, there will be racing condition.
> > -*/
> >  static inline u32 _down_sema(struct semaphore *sema)
> >  {
> >  	if (down_interruptible(sema))
> 
> This function sucks obviously just like the wrappers you deleted earlier.
> 
> Only one of the callers checks the return value.
> 
> TODO-list: 2014-07-08: rtl8712: delete _down_sema().
> 
> regards,
> dan carpenter
> 

I completely agree -- most of the stuff in this header is pretty ugly.  More
clean-up patches are in the pipe.

Regards,
James Shackleford
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/