linux-kernel - Re: [PATCH v3 3/5] phy: miphy365x: Provide support for the MiPHY356x Generic PHY

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 11 Jul 2014 11:07:00 +0200
From:	Gabriel Fernandez <gabriel.fernandez@...aro.org>
To:	Lee Jones <lee.jones@...aro.org>
Cc:	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Kishon <kishon@...com>,
	"kernel@...inux.com" <kernel@...inux.com>,
	Alexandre Torgue <alexandre.torgue@...com>
Subject: Re: [PATCH v3 3/5] phy: miphy365x: Provide support for the MiPHY356x
 Generic PHY

Hi Lee

One suggestion

On 9 July 2014 13:41, Lee Jones <lee.jones@...aro.org> wrote:
> The MiPHY365x is a Generic PHY which can serve various SATA or PCIe
> devices. It has 2 ports which it can use for either; both SATA, both
> PCIe or one of each in any configuration.
>
> Acked-by: Mark Rutland <mark.rutland@....com>
> Signed-off-by: Alexandre Torgue <alexandre.torgue@...com>
> Signed-off-by: Lee Jones <lee.jones@...aro.org>
> ---
>  drivers/phy/Kconfig         |  10 +
>  drivers/phy/Makefile        |   1 +
>  drivers/phy/phy-miphy365x.c | 616 ++++++++++++++++++++++++++++++++++++++++++++
>  3 files changed, 627 insertions(+)
>  create mode 100644 drivers/phy/phy-miphy365x.c
>

[...]

> diff --git a/drivers/phy/phy-miphy365x.c b/drivers/phy/phy-miphy365x.c
> new file mode 100644
> index 0000000..65ecd04
> --- /dev/null
> +++ b/drivers/phy/phy-miphy365x.c
> @@ -0,0 +1,616 @@

[...]

> +
> +struct miphy365x_phy {
> +       struct phy *phy;
> +       void __iomem *base;
> +       void __iomem *sata;
> +       void __iomem *pcie;
> +       u8 type;
> +       u8 port;


if we add:
     struct miphy365x_dev *phydev;

it's could simplified call of procedures below ?

for e.g.
static int miphy365x_set_path(struct miphy365x_phy *miphy_phy,
                             struct miphy365x_dev *miphy_dev)

into

static int miphy365x_set_path(struct miphy365x_phy *miphy_phy)
{
    struct miphy365x_dev *miphy_dev=miphy_phy->phydev;


[...]

Best regards
Gabriel
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/