linux-kernel - Re: randconfig build error with next-20140710, in sound/soc/rockchip/rockchip

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 11 Jul 2014 10:32:21 +1000
From:	Stephen Rothwell <sfr@...b.auug.org.au>
To:	Jianqun <xjq@...k-chips.com>
Cc:	Jim Davis <jim.epost@...il.com>,
	linux-next <linux-next@...r.kernel.org>,
	linux-kernel <linux-kernel@...r.kernel.org>, lgirdwood@...il.com,
	broonie@...nel.org, perex@...ex.cz, tiwai@...e.de,
	grant.likely@...aro.org, robh+dt@...nel.org,
	devicetree@...r.kernel.org
Subject: Re: randconfig build error with next-20140710, in
 sound/soc/rockchip/rockchip_i2s.c

Hi Jianqun,

On Fri, 11 Jul 2014 08:07:20 +0800 Jianqun <xjq@...k-chips.com> wrote:
>
> Is it caused by the headfile ?
> #include <linux/module.h>
> 
> Adviced by the maintainers, I tried not to include the headfile one by one, then to compile
> driver each time, I found that is success to compile it without module.h, of course

Who ever gave you that advice is wrong.  You should always (except in
very rare circumstances) include every header file that your code
references things from.  We have over 20 architectures and many, many
possible configurations in the kernel build system and the fact that a
file builds for one is not guarantee that it will build for another
combination if you depend on implicit includes.

See Rule 1 in Documentation/SubmitChecklist.

> I just compiled driver with command "ARCH=arm".

Which just proves my point.

-- 
Cheers,
Stephen Rothwell                    sfr@...b.auug.org.au

Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)