linux-kernel - Re: [PATCH 1/1] script/kconfig: remove a warning for menucofig

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 14 Jul 2014 14:25:16 +0800
From:	"Li, ZhenHua" <zhen-hual@...com>
To:	Heinrich Schuchardt <xypron.glpk@....de>,
	"Yann E. MORIN" <yann.morin.1998@...e.fr>
CC:	linux-kbuild@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/1] script/kconfig: remove a warning for menucofig

Any update?

On 07/01/2014 01:02 AM, Heinrich Schuchardt wrote:
> On 30.06.2014 05:16, Li, Zhen-Hua wrote:
>> There is a warning when run "make menuconfig".
>>
>> scripts/kconfig/menu.c: In function ‘get_symbol_str’:
>> scripts/kconfig/menu.c:591:18: warning: ‘jump’ may be used 
>> uninitialized in
>> this function [-Wmaybe-uninitialized]
>>       jump->offset = strlen(r->s);
>>                    ^
>> scripts/kconfig/menu.c:551:19: note: ‘jump’ was declared here
>>    struct jump_key *jump;
>>                     ^
>>
>> It is because the compiler think "jump" is not initialized, though in 
>> fact
>> it is already initialized.
>>
>> Signed-off-by: Li, Zhen-Hua <zhen-hual@...com>
>> ---
>>   scripts/kconfig/menu.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/scripts/kconfig/menu.c b/scripts/kconfig/menu.c
>> index a26cc5d..584e0fc 100644
>> --- a/scripts/kconfig/menu.c
>> +++ b/scripts/kconfig/menu.c
>> @@ -548,7 +548,7 @@ static void get_prompt_str(struct gstr *r, struct 
>> property *prop,
>>   {
>>       int i, j;
>>       struct menu *submenu[8], *menu, *location = NULL;
>> -    struct jump_key *jump;
>> +    struct jump_key *jump = NULL;
>>
>>       str_printf(r, _("Prompt: %s\n"), _(prop->text));
>>       menu = prop->menu->parent;
>>
> Hello Zhen-Hua,
>
> the patch looks incomplete to me. A check
> jump != NULL
> should be added before accessing parts of structure jump_key.
>
> Best regards
>
> Heinrich Schuchardt

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/