linux-kernel - Re: [PATCH] xillybus: place 'else' on same line as '}'

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 14 Jul 2014 09:40:39 +0300
From:	Eli Billauer <eli.billauer@...il.com>
To:	Jeremiah Mahler <jmmahler@...il.com>
Cc:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Wei Yongjun <yongjun_wei@...ndmicro.com.cn>,
	Kees Cook <keescook@...omium.org>,
	Masanari Iida <standby24x7@...il.com>,
	Richard Weinberger <richard@....at>,
	Ebru Akagunduz <ebru.akagunduz@...il.com>,
	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] xillybus: place 'else' on same line as '}'

Hi,

Thanks for this.

And since I looked at the part in Codingstyle that deals with if-else, I 
found another few mistakes regarding braces around a single statement. 
The rules say, it turns out, that if one of the clauses in an if-else is 
longer than one statement, both clauses should be wrapped with braces. 
This rule is broken in lines 162, 536 and 613 of the same file.

To avoid possible conflicts, I'll wait for this patch to be applied, and 
submit my corrections after that.

Regards,
    Eli


On 14/07/14 06:07, Jeremiah Mahler wrote:
> Place 'else' on same line as closing brace '}' as per
> Documentation/CodingStyle.  Fixes 1 error found by checkpatch.pl.
>
> Signed-off-by: Jeremiah Mahler<jmmahler@...il.com>
> ---
>   drivers/staging/xillybus/xillybus_core.c | 3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/staging/xillybus/xillybus_core.c b/drivers/staging/xillybus/xillybus_core.c
> index ab6502c..7de4c11 100644
> --- a/drivers/staging/xillybus/xillybus_core.c
> +++ b/drivers/staging/xillybus/xillybus_core.c
> @@ -546,8 +546,7 @@ static int xilly_setupchannels(struct xilly_endpoint *ep,
>   			channel->rd_buffers = buffers;
>   			rc = xilly_get_dma_buffers(ep,&rd_alloc, buffers,
>   						   bufnum, bytebufsize);
> -		}
> -		else if (channelnum>  0) {
> +		} else if (channelnum>  0) {
>   			channel->num_wr_buffers = bufnum;
>
>   			channel->seekable = seekable;
>    

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/