linux-kernel - Re: [PATCH v2 19/29] nios2: Time keeping

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 15 Jul 2014 12:00:03 +0200 (CEST)
From:	Thomas Gleixner <tglx@...utronix.de>
To:	Ley Foon Tan <lftan@...era.com>
cc:	linux-arch@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-doc@...r.kernel.org, lftan.linux@...il.com,
	cltang@...esourcery.com
Subject: Re: [PATCH v2 19/29] nios2: Time keeping

On Tue, 15 Jul 2014, Ley Foon Tan wrote:
> --- /dev/null
> +++ b/arch/nios2/kernel/time.c
> @@ -0,0 +1,150 @@
> +/*
> + * Copyright (C) 2013 Altera Corporation
> + * Copyright (C) 2010 Tobias Klauser <tklauser@...tanz.ch>
> + * Copyright (C) 2004 Microtronix Datacom Ltd.
> + *
> + * This file is subject to the terms and conditions of the GNU General Public
> + * License. See the file "COPYING" in the main directory of this archive
> + * for more details.
> + */
> +
> +#include <linux/init.h>
> +#include <linux/sched.h>
> +#include <linux/interrupt.h>
> +#include <linux/time.h>
> +#include <linux/timex.h>
> +#include <linux/profile.h>
> +#include <linux/clocksource.h>
> +#include <linux/of.h>
> +#include <linux/of_address.h>
> +#include <linux/of_irq.h>
> +#include <linux/io.h>
> +
> +#define	TICK_SIZE		(tick_nsec / 1000)
> +#define NIOS2_TIMER_PERIOD	(timer_freq / HZ)
> +
> +#define ALTERA_TIMER_STATUS_REG		0
> +#define ALTERA_TIMER_CONTROL_REG	4
> +#define ALTERA_TIMER_PERIODL_REG	8
> +#define ALTERA_TIMER_PERIODH_REG	12
> +#define ALTERA_TIMER_SNAPL_REG		16
> +#define ALTERA_TIMER_SNAPH_REG		20
> +
> +#define ALTERA_TIMER_CONTROL_ITO_MSK	(0x1)
> +#define ALTERA_TIMER_CONTROL_CONT_MSK	(0x2)
> +#define ALTERA_TIMER_CONTROL_START_MSK	(0x4)
> +#define ALTERA_TIMER_CONTROL_STOP_MSK	(0x8)
> +
> +static u32 nios2_timer_count;
> +static void __iomem *timer_membase;
> +static u32 timer_freq;
> +
> +static inline unsigned long read_timersnapshot(void)
> +{
> +	unsigned long count;
> +
> +	writew(0, timer_membase + ALTERA_TIMER_SNAPL_REG);
> +	count =
> +		readw(timer_membase + ALTERA_TIMER_SNAPH_REG) << 16 |
> +		readw(timer_membase + ALTERA_TIMER_SNAPL_REG);

So you're serious about having a new architecture with a timer
implementation which cant read 32bit in one go? I'm impressed ...

> +	return count;
> +}
> +
> +static inline void write_timerperiod(unsigned long period)
> +{
> +	writew(period, timer_membase + ALTERA_TIMER_PERIODL_REG);
> +	writew(period >> 16, timer_membase + ALTERA_TIMER_PERIODH_REG);
> +}
> +
> +/*
> + * timer_interrupt() needs to keep up the real-time clock,
> + * as well as call the "xtime_update()" routine every clocktick
> + */
> +irqreturn_t timer_interrupt(int irq, void *dummy)
> +{
> +	/* Clear the interrupt condition */
> +	writew(0, timer_membase + ALTERA_TIMER_STATUS_REG);
> +	nios2_timer_count += NIOS2_TIMER_PERIOD;
> +
> +	profile_tick(CPU_PROFILING);
> +
> +	xtime_update(1);
> +
> +	update_process_times(user_mode(get_irq_regs()));
> +
> +	return IRQ_HANDLED;

Please use the clock events infrastructure. New users of the old style
timer management are not welcome.

> +}
> +
> +static cycle_t nios2_timer_read(struct clocksource *cs)
> +{
> +	unsigned long flags;
> +	u32 cycles;
> +	u32 tcn;
> +
> +	local_irq_save(flags);
> +	tcn = NIOS2_TIMER_PERIOD - 1 - read_timersnapshot();
> +	cycles = nios2_timer_count;

This is wrong and completely pointless. The core code takes care about
the offset.

> +	local_irq_restore(flags);
> +
> +	return cycles + tcn;
> +}

Thanks,

	tglx
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/