linux-kernel - Re: [PATCH 05/38] tile: clean up Kbuild files

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 17 Jul 2014 15:41:39 -0400
From:	Chris Metcalf <cmetcalf@...era.com>
To:	Sam Ravnborg <sam@...nborg.org>, Arnd Bergmann <arnd@...db.de>
CC:	lkml <linux-kernel@...r.kernel.org>,
	linux-arch <linux-arch@...r.kernel.org>,
	David Howells <dhowells@...hat.com>
Subject: Re: [PATCH 05/38] tile: clean up Kbuild files

On 7/14/2014 11:08 AM, Sam Ravnborg wrote:
> Drop an unused Kbuild file - it was anyway empty
> Drop an irrelevent assignment to header-y
>
> Signed-off-by: Sam Ravnborg <sam@...nborg.org>
> Cc: Chris Metcalf <cmetcalf@...era.com>
> Cc: David Howells <dhowells@...hat.com>
> ---
>   arch/tile/include/arch/Kbuild | 1 -
>   arch/tile/include/asm/Kbuild  | 3 ---
>   2 files changed, 4 deletions(-)
>   delete mode 100644 arch/tile/include/arch/Kbuild
>
> diff --git a/arch/tile/include/arch/Kbuild b/arch/tile/include/arch/Kbuild
> deleted file mode 100644
> index 3751c9f..0000000
> --- a/arch/tile/include/arch/Kbuild
> +++ /dev/null
> @@ -1 +0,0 @@
> -# Tile arch headers

Acked-by: Chris Metcalf <cmetcalf@...era.com>

for this piece.  David Howells left these with just comments originally,
but removing the file entirely seems fine too.

> diff --git a/arch/tile/include/asm/Kbuild b/arch/tile/include/asm/Kbuild
> index 0aa5675..3013a07 100644
> --- a/arch/tile/include/asm/Kbuild
> +++ b/arch/tile/include/asm/Kbuild
> @@ -1,6 +1,3 @@
> -
> -header-y += ../arch/
> -
>   generic-y += bug.h
>   generic-y += bugs.h
>   generic-y += clkdev.h

Nack for this patch.  The arch/ headers are all intended to be shared by the
kernel and userspace, so we install them from the kernel.  This one header-y
line installs the 16 header files in usr/include/arch/*.h.  If there's a
better way to make that happen, that would be fine too, of course.

Arguably we could provide them separately (a tarball from tilera.com or
something) but frankly, this just makes the standard build flows for kernel,
gcc, and glibc more non-standard for tile, which seems like a bad thing.

-- 
Chris Metcalf, Tilera Corp.
http://www.tilera.com

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/