linux-kernel - Re: [PATCH v2 15/29] nios2: System calls handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 18 Jul 2014 13:56:43 +0100
From:	James Hogan <james.hogan@...tec.com>
To:	Ley Foon Tan <lftan@...era.com>, <linux-arch@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>, <linux-doc@...r.kernel.org>
CC:	<lftan.linux@...il.com>, <cltang@...esourcery.com>,
	Arnd <arnd@...db.de>
Subject: Re: [PATCH v2 15/29] nios2: System calls handling

Hi,

On 15/07/14 09:45, Ley Foon Tan wrote:
> This patch adds support for system calls from userspaces. It uses the
> asm-generic/unistd.h definitions with architecture spcific syscall. The sys_call_table
> is just an array defined in a C file and it contains pointers to the syscall functions.

I don't think you need the renameat syscall now that renameat2 exists.

Can I suggest preceding your patchset with this patch:
https://lkml.org/lkml/2014/4/23/197
([RFC 3/3] asm-generic: Drop renameat syscall from default list)

which drops renameat from the generic list unless __ARCH_WANT_RENAMEAT
is defined in the arch's uapi/asm/unistd.h.

Cheers
James
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/