linux-kernel - Re: [PATCH] staging: input: sunkbd.c: Fix coding style

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 20 Jul 2014 08:52:54 -0700
From:	Joe Perches <joe@...ches.com>
To:	Bivolaru Catalin <bivolaru.catalin@...il.com>
Cc:	kernel-janitors@...r.kernel.org, dmitry.torokhov@...il.com,
	linux-input@...r.kernel.org, linux-kernel@...r.kernel.org,
	paul.gortmaker@...driver.com
Subject: Re: [PATCH] staging: input: sunkbd.c: Fix coding style

On Sun, 2014-07-20 at 15:01 +0300, Bivolaru Catalin wrote:
> Fix coding style with regard to missing spaces after , and the column limit
> that was violated after the first change.

Some checkpatch errors should be ignored.

These are some of them.

This change doesn't make it easier to read
or to find any array entry.

It's currently in groups of 16 (0x10).

This change would make it very difficult
to find any particular entry.

It might make some sense to change the last
line to add a trailing "  0,  0" entry as
the compiler does to make it a bit clearer
the table has 128 entries.

> diff --git a/drivers/input/keyboard/sunkbd.c b/drivers/input/keyboard/sunkbd.c
[]
> @@ -42,14 +42,15 @@ MODULE_DESCRIPTION(DRIVER_DESC);
>  MODULE_LICENSE("GPL");
>  
>  static unsigned char sunkbd_keycode[128] = {
> -	  0,128,114,129,115, 59, 60, 68, 61, 87, 62, 88, 63,100, 64,112,
> -	 65, 66, 67, 56,103,119, 99, 70,105,130,131,108,106,  1,  2,  3,
> -	  4,  5,  6,  7,  8,  9, 10, 11, 12, 13, 41, 14,110,113, 98, 55,
> -	116,132, 83,133,102, 15, 16, 17, 18, 19, 20, 21, 22, 23, 24, 25,
> -	 26, 27,111,127, 71, 72, 73, 74,134,135,107,  0, 29, 30, 31, 32,
> -	 33, 34, 35, 36, 37, 38, 39, 40, 43, 28, 96, 75, 76, 77, 82,136,
> -	104,137, 69, 42, 44, 45, 46, 47, 48, 49, 50, 51, 52, 53, 54,101,
> -	 79, 80, 81,  0,  0,  0,138, 58,125, 57,126,109, 86, 78
> +	  0, 128, 114, 129, 115,  59,  60,  68,  61,  87,  62,  88,  63, 100,
> +	 64, 112,  65,  66,  67,  56, 103, 119,  99,  70, 105, 130, 131, 108,
> +	106,   1,   2,   3,   4,   5,   6,   7,   8,   9,  10,  11,  12,  13,
> +	 41,  14, 110, 113,  98,  55, 116, 132,  83, 133, 102,  15,  16,  17,
> +	 18,  19,  20,  21,  22,  23,  24,  25,  26,  27, 111, 127,  71,  72,
> +	 73,  74, 134, 135, 107,   0,  29,  30,  31,  32,  33,  34,  35,  36,
> +	 37,  38,  39,  40,  43,  28,  96,  75,  76,  77,  82, 136, 104, 137,
> +	 69,  42,  44,  45,  46,  47,  48,  49,  50,  51,  52,  53,  54, 101,
> +	 79,  80,  81,   0,   0,   0, 138,  58, 125,  57, 126, 109,  86,  78
>  };


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/