linux-kernel - Re: Re: Re: [PATCH] lib : lz4 using put_unaligned_le16 instead of put

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:	Tue, 22 Jul 2014 03:15:31 +0000 (GMT)
From:	Eunbong Song <eunb.song@...sung.com>
To:	Greg KH <gregkh@...uxfoundation.org>
Cc:	"chanho.min@....com" <chanho.min@....com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: Re: Re: [PATCH] lib : lz4 using put_unaligned_le16 instead of
 put_unaligned

> So it's never worked?
Yes, it's always failed to mount. 
> Did you test on a little endian machine after making this change?
Unfortunately, i don't have little endian machine. So i couldn't test that.

Additionaly, when lz4 compress calls lz4_compressctx() function and uses LZ4_WRITE_LITTLEENDIAN_16() macro.
And When lz4 decompress  calls lz4_uncompress_unknownoutputsize function and 
uses LZ4_READ_LITTLEENDIAN_16 macro.
There is endian mismatch in big endian machine as i metioned before. when compress lz4 write big endian bytes order
and when decompress lz4 reads little endian bytes order. 
So i means we should make there is no endian mismatch between compress and decompress operation.

Thanks.