linux-kernel - Re: [PATCH 52/52] perf tools: Add support for 32-bit compatibility VDSOs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 24 Jul 2014 08:35:28 +0900
From:	Namhyung Kim <namhyung@...nel.org>
To:	Adrian Hunter <adrian.hunter@...el.com>
Cc:	Jiri Olsa <jolsa@...hat.com>,
	Arnaldo Carvalho de Melo <acme@...nel.org>,
	Peter Zijlstra <peterz@...radead.org>,
	linux-kernel@...r.kernel.org, David Ahern <dsahern@...il.com>,
	Frederic Weisbecker <fweisbec@...il.com>,
	Paul Mackerras <paulus@...ba.org>,
	Stephane Eranian <eranian@...gle.com>
Subject: Re: [PATCH 52/52] perf tools: Add support for 32-bit compatibility VDSOs

Hi Adrian,

On Wed, 23 Jul 2014 16:59:39 +0300, Adrian Hunter wrote:
> On 07/23/2014 04:02 PM, Jiri Olsa wrote:
>> On Tue, Jul 22, 2014 at 04:18:01PM +0300, Adrian Hunter wrote:
>>> 'perf record' post-processes the event stream  to create
>>> a list of build-ids for object files for which sample
>>> events have been recorded.  That results in those object
>>> files being recorded in the build-id cache.
>> 
>> SNIP
>> 
>>>  
>>>  	if (vdso_info->vdso.found)
>>>  		unlink(vdso_info->vdso.temp_file_name);
>>> +#if BITS_PER_LONG == 64
>>> +	if (vdso_info->vdso32.found)
>>> +		unlink(vdso_info->vdso.temp_file_name);
>>> +	if (vdso_info->vdsox32.found)
>>> +		unlink(vdso_info->vdso.temp_file_name);
>>> +#endif

Looks like copy-and-paste errors.  Did you mean below?

#if BITS_PER_LONG == 64
	if (vdso_info->vdso32.found)
		unlink(vdso_info->vdso32.temp_file_name);
	if (vdso_info->vdsox32.found)
		unlink(vdso_info->vdsox32.temp_file_name);
#endif

                                      ^^^


Thanks,
Namhyung
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/