linux-kernel - Re: [RFC PATCH v1 12/70] x86, pci, amd_bus:

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 23 Jul 2014 21:31:30 -0400
From:	"Chen, Gong" <gong.chen@...ux.intel.com>
To:	Borislav Petkov <bp@...en8.de>
Cc:	linux-kernel@...r.kernel.org, mingo@...nel.org, tglx@...utronix.de,
	paulus@...ba.org, benh@...nel.crashing.org, tony.luck@...el.com,
	hpa@...or.com, jkosina@...e.cz, rafael.j.wysocki@...el.com,
	linux@....linux.org.uk, ralf@...ux-mips.org,
	schwidefsky@...ibm.com, davem@...emloft.net,
	viro@...iv.linux.org.uk, fweisbec@...il.com, cl@...ux.com,
	akpm@...ux-foundation.org, axboe@...nel.dk,
	JBottomley@...allels.com, neilb@...e.de,
	christoffer.dall@...aro.org, rostedt@...dmis.org, rric@...nel.org,
	gregkh@...uxfoundation.org, mhocko@...e.cz, david@...morbit.com
Subject: Re: [RFC PATCH v1 12/70] x86, pci, amd_bus: _FROZEN Cleanup

On Wed, Jul 23, 2014 at 08:07:18PM +0200, Borislav Petkov wrote:
> Date: Wed, 23 Jul 2014 20:07:18 +0200
> From: Borislav Petkov <bp@...en8.de>
> To: "Chen, Gong" <gong.chen@...ux.intel.com>
> Cc: linux-kernel@...r.kernel.org, mingo@...nel.org, tglx@...utronix.de,
>  paulus@...ba.org, benh@...nel.crashing.org, tony.luck@...el.com,
>  hpa@...or.com, jkosina@...e.cz, rafael.j.wysocki@...el.com,
>  linux@....linux.org.uk, ralf@...ux-mips.org, schwidefsky@...ibm.com,
>  davem@...emloft.net, viro@...iv.linux.org.uk, fweisbec@...il.com,
>  cl@...ux.com, akpm@...ux-foundation.org, axboe@...nel.dk,
>  JBottomley@...allels.com, neilb@...e.de, christoffer.dall@...aro.org,
>  rostedt@...dmis.org, rric@...nel.org, gregkh@...uxfoundation.org,
>  mhocko@...e.cz, david@...morbit.com
> Subject: Re: [RFC PATCH v1 12/70] x86, pci, amd_bus: _FROZEN Cleanup
> User-Agent: Mutt/1.5.23 (2014-03-12)
> 
> On Tue, Jul 22, 2014 at 09:58:48PM -0400, Chen, Gong wrote:
> > Remove XXX_FROZEN state from x86/pci/amd_bus.
> > 
> > Signed-off-by: Chen, Gong <gong.chen@...ux.intel.com>
> > ---
> >  arch/x86/pci/amd_bus.c | 3 +--
> >  1 file changed, 1 insertion(+), 2 deletions(-)
> > 
> > diff --git a/arch/x86/pci/amd_bus.c b/arch/x86/pci/amd_bus.c
> > index c20d2cc..30f0fca9 100644
> > --- a/arch/x86/pci/amd_bus.c
> > +++ b/arch/x86/pci/amd_bus.c
> > @@ -341,9 +341,8 @@ static int amd_cpu_notify(struct notifier_block *self, unsigned long action,
> >  			  void *hcpu)
> >  {
> >  	int cpu = (long)hcpu;
> > -	switch (action) {
> > +	switch (action & ~CPU_TASKS_FROZEN) {
> >  	case CPU_ONLINE:
> > -	case CPU_ONLINE_FROZEN:
> >  		smp_call_function_single(cpu, enable_pci_io_ecs, NULL, 0);
> >  		break;
> >  	default:
> 
> Or you can kill all the switch-case gunk and make it even more readable:
> 
But what if new action is added? We have to change it back. If you prefer
to use that style I can update in next version.

Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)