linux-kernel - Re: [can-next PATCH 1/1] net: can: c_can_platform: Use devm_ioremap instead of devm_ioremap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 25 Jul 2014 12:49:25 +0200
From:	Wolfram Sang <wsa@...g-engineering.com>
To:	Mugunthan V N <mugunthanvnm@...com>
Cc:	Wolfgang Grandegger <wg@...ndegger.com>,
	Marc Kleine-Budde <mkl@...gutronix.de>,
	Pavel Machek <pavel@...x.de>, Thor Thayer <tthayer@...era.com>,
	Prabhakar Lad <prabhakar.csengg@...il.com>,
	Thomas Gleixner <tglx@...utronix.de>,
	Chen Gang <gang.chen@...anux.com>,
	George Cherian <george.cherian@...com>,
	linux-can@...r.kernel.org, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [can-next PATCH 1/1] net: can: c_can_platform: Use devm_ioremap instead of devm_ioremap_resource.

Am 25-07-2014 08:19, schrieb Mugunthan V N:
> From: George Cherian <george.cherian@...com>
> 
> The raminit register is shared register for both can0 and can1.
> Using devm_ioremap_resource fails the mapping for can1 interface
> leading to a non functional can interface.
> 
> Signed-off-by: George Cherian <george.cherian@...com>
> Signed-off-by: Mugunthan V N <mugunthanvnm@...com>

The patch is a hack, or? It simply works because we drop all sanity 
checking on the resource.

I am on holiday and can't really check, yet I believe the AM335x has 
devicetree support for accessing single bits in SYSCONF. This is what 
needs to be applied here, too, AFAICT.

> ---
>  drivers/net/can/c_can/c_can_platform.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/net/can/c_can/c_can_platform.c
> b/drivers/net/can/c_can/c_can_platform.c
> index e29b6d0..5dede6e 100644
> --- a/drivers/net/can/c_can/c_can_platform.c
> +++ b/drivers/net/can/c_can/c_can_platform.c
> @@ -278,7 +278,8 @@ static int c_can_plat_probe(struct platform_device 
> *pdev)
>  			break;
>  		}
> 
> -		priv->raminit_ctrlreg = devm_ioremap_resource(&pdev->dev, res);
> +		priv->raminit_ctrlreg = devm_ioremap(&pdev->dev, res->start,
> +						     resource_size(res));
>  		if (IS_ERR(priv->raminit_ctrlreg) || priv->instance < 0)
>  			dev_info(&pdev->dev, "control memory is not used for raminit\n");
>  		else
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/