linux-kernel - Re: [PATCH v2 RESEND 13/23] megaraid: Fail resume if MSI-X re-initialization failed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sat, 26 Jul 2014 09:24:09 +0100
From:	Alexander Gordeev <agordeev@...hat.com>
To:	linux-kernel@...r.kernel.org,
	Neela Syam Kolli <megaraidlinux@....com>
Subject: Re: [PATCH v2 RESEND 13/23] megaraid: Fail resume if MSI-X
 re-initialization failed

On Wed, Jul 16, 2014 at 08:05:17PM +0200, Alexander Gordeev wrote:
> Currently the driver fails to analize MSI-X re-enablement
> status on resuming and always assumes the success. This
> update checks the MSI-X initialization result and fails
> to resume if MSI-Xs re-enablement failed.

Hi Neela,

Could you please review megaraid patches in this series?

Thanks!

> Signed-off-by: Alexander Gordeev <agordeev@...hat.com>
> ---
>  drivers/scsi/megaraid/megaraid_sas_base.c |    8 +++++---
>  1 files changed, 5 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/scsi/megaraid/megaraid_sas_base.c b/drivers/scsi/megaraid/megaraid_sas_base.c
> index 112799b..ba06102 100644
> --- a/drivers/scsi/megaraid/megaraid_sas_base.c
> +++ b/drivers/scsi/megaraid/megaraid_sas_base.c
> @@ -5134,9 +5134,10 @@ megasas_resume(struct pci_dev *pdev)
>  		goto fail_ready_state;
>  
>  	/* Now re-enable MSI-X */
> -	if (instance->msix_vectors)
> -		pci_enable_msix(instance->pdev, instance->msixentry,
> -				instance->msix_vectors);
> +	if (instance->msix_vectors &&
> +	    pci_enable_msix(instance->pdev, instance->msixentry,
> +			    instance->msix_vectors))
> +		goto fail_reenable_msix;
>  
>  	switch (instance->pdev->device) {
>  	case PCI_DEVICE_ID_LSI_FUSION:
> @@ -5245,6 +5246,7 @@ fail_init_mfi:
>  
>  fail_set_dma_mask:
>  fail_ready_state:
> +fail_reenable_msix:
>  
>  	pci_disable_device(pdev);
>  
> -- 
> 1.7.7.6
> 

-- 
Regards,
Alexander Gordeev
agordeev@...hat.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/