lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 29 Jul 2014 09:53:25 +0800 From: ethan zhao <ethan.zhao@...cle.com> To: Alex Williamson <alex.williamson@...hat.com> CC: bhelgaas@...gle.com, linux-pci@...r.kernel.org, linux-kernel@...r.kernel.org, gleb@...nel.org, pbonzini@...hat.com, kvm@...r.kernel.org, konrad.wilk@...cle.com, boris.ostrovsky@...cle.com, david.vrabel@...rix.com, xen-devel@...ts.xenproject.org, alexander.h.duyck@...el.com, ethan.kernel@...il.com Subject: Re: [PATCH 1/4] PCI: introduce helper functions for device flag operation On 2014/7/29 5:00, Alex Williamson wrote: > On Wed, 2014-07-23 at 00:19 +0800, Ethan Zhao wrote: >> This patch introduced three helper functions to hide direct >> device flag operation. >> >> void pci_set_dev_assigned(struct pci_dev *pdev); >> void pci_set_dev_deassigned(struct pci_dev *pdev); >> bool pci_is_dev_assigned(struct pci_dev *pdev); >> >> Signed-off-by: Ethan Zhao <ethan.zhao@...cle.com> >> --- >> include/linux/pci.h | 13 +++++++++++++ >> 1 files changed, 13 insertions(+), 0 deletions(-) >> >> diff --git a/include/linux/pci.h b/include/linux/pci.h >> index aab57b4..5f6f8fa 100644 >> --- a/include/linux/pci.h >> +++ b/include/linux/pci.h >> @@ -1129,6 +1129,19 @@ resource_size_t pcibios_window_alignment(struct pci_bus *bus, >> >> int pci_set_vga_state(struct pci_dev *pdev, bool decode, >> unsigned int command_bits, u32 flags); >> +/* helper functions for operation of device flag */ >> +static inline void pci_set_dev_assigned(struct pci_dev *pdev) >> +{ >> + pdev->dev_flags |= PCI_DEV_FLAGS_ASSIGNED; >> +} >> +static inline void pci_set_dev_deassigned(struct pci_dev *pdev) >> +{ >> + pdev->dev_flags &= ~PCI_DEV_FLAGS_ASSIGNED; >> +} > I think pci_clear_dev_assigned() would make more sense, we're not > setting a flag named DEASSIGNED. Though it is a flag operation now, may not later, we define it because we want to hide the internal operation. 'set' to 'deassigned' status is enough. So I would like keep it. > >> +static inline bool pci_is_dev_assigned(struct pci_dev *pdev) >> +{ >> + return pdev->dev_flags & PCI_DEV_FLAGS_ASSIGNED ? true : false; >> +} > The ternary operation isn't necessary. Thanks, Yep, return pdev->dev_flags & PCI_DEV_FLAGS_ASSIGNED is enough. Thanks, Ethan > > Alex > >> /* kmem_cache style wrapper around pci_alloc_consistent() */ >> >> #include <linux/pci-dma.h> > > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists