linux-kernel - Re: [PATCH v2] i2c: pca954x: put the mux to disconnected state after resume

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 1 Aug 2014 19:57:05 +0200
From:	Wolfram Sang <wsa@...-dreams.de>
To:	Jisheng Zhang <jszhang@...vell.com>
Cc:	laurent.pinchart@...asonboard.com, khali@...ux-fr.org,
	paul.gortmaker@...driver.com, linux-i2c@...r.kernel.org,
	linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH v2] i2c: pca954x: put the mux to disconnected state after
 resume

On Fri, Jul 25, 2014 at 07:57:46PM +0800, Jisheng Zhang wrote:
> pca954x may be power lost during suspend, so after resume we also suffer
> the issue fixed by commit cd823db8b1161ef0d756514d280715a576d65cc3,
> 
>  "pca954x power-on default is channel 0 connected. If multiple pca954x
>  muxes are connected to the same physical I2C bus, the parent bus will
>  see channel 0 devices behind both muxes by default."
> 
> What's more, when resume bootloader may also operate the mux, so the
> the channel connected after that may not be the one driver thought.
> 
> We fix this problem by putting the mux to disconnected state and
> clearing last_chan in the resume hook.
> 
> Signed-off-by: Jisheng Zhang <jszhang@...vell.com>

Applied to for-next, thanks!


Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)