linux-kernel - [PATCH] zram: return EBUSY when max_comp_streams change fails for device in use

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Sun,  3 Aug 2014 23:48:49 +0100
From:	Sami Kerola <kerolasa@....fi>
To:	linux-kernel@...r.kernel.org
Cc:	kerolasa@....fi, Minchan Kim <minchan@...nel.org>,
	Nitin Gupta <ngupta@...are.org>,
	Sergey Senozhatsky <sergey.senozhatsky@...il.com>
Subject: [PATCH] zram: return EBUSY when max_comp_streams change fails for device in use

Both disksize and comp_algorithm return EBUSY when a change is attempted
to a device in use, and so should max_comp_streams.

Signed-off-by: Sami Kerola <kerolasa@....fi>
---
 drivers/block/zram/zram_drv.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/block/zram/zram_drv.c b/drivers/block/zram/zram_drv.c
index 36e54be..0211734 100644
--- a/drivers/block/zram/zram_drv.c
+++ b/drivers/block/zram/zram_drv.c
@@ -139,7 +139,7 @@ static ssize_t max_comp_streams_store(struct device *dev,
 	if (init_done(zram)) {
 		if (!zcomp_set_max_streams(zram->comp, num)) {
 			pr_info("Cannot change max compression streams\n");
-			ret = -EINVAL;
+			ret = -EBUSY;
 			goto out;
 		}
 	}
-- 
2.0.3

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/