linux-kernel - Re: [PATCH] cpufreq, store_scaling_governor requires policy->rwsem to be held for duration of changing governors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 4 Aug 2014 15:24:40 +0530
From:	Viresh Kumar <viresh.kumar@...aro.org>
To:	Prarit Bhargava <prarit@...hat.com>
Cc:	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	"Rafael J. Wysocki" <rjw@...ysocki.net>,
	Lenny Szubowicz <lszubowi@...hat.com>,
	"linux-pm@...r.kernel.org" <linux-pm@...r.kernel.org>
Subject: Re: [PATCH] cpufreq, store_scaling_governor requires policy->rwsem to
 be held for duration of changing governors

On 25 July 2014 18:11, Prarit Bhargava <prarit@...hat.com> wrote:
> Okay -- I think I got it:  The above happens only with an *older* sysfs stack
> which acquires a &buffer->mutex.  This no longer happens with the new sysfs
> stack so the above change is still no longer necessary in mainline linux.git (at
> least AFAICT).

Hmm, that's something new for me. Would it be possible to give some commits
for reference where the behavior changed? This would be quite helpful once
we face it again and need to come back to this thread :)

> In any case, the change still appears to be incorrect in that it breaks the
> rwsem locking scheme of the cpufreq policy.  I'll do some additional testing on
> various systems and get back to you in a few days.

What about breaking rwsem locking scheme?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/