linux-kernel - Re: [PATCH] jffs2: Re-enable write-buffering after filesystem sync

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 4 Aug 2014 14:02:19 -0400
From:	Jeff Harris <jefftharris@...il.com>
To:	Al Viro <viro@...iv.linux.org.uk>
Cc:	David Woodhouse <dwmw2@...radead.org>,
	linux-mtd@...ts.infradead.org, linux-kernel@...r.kernel.org,
	Jeff Harris <jharris@...tell.com>
Subject: Re: [PATCH] jffs2: Re-enable write-buffering after filesystem sync

On Fri, Aug 1, 2014 at 3:13 PM, Al Viro <viro@...iv.linux.org.uk> wrote:
> Why do we need ->wbuf_queued, anyway?  It's not as if queue_delayed_work()
> wouldn't do the right thing - if the sucker already has WORK_STRUCT_PENDING_BIT
> set it'll simply do nothing.  And it won't spend much time finding that
> out - in fact, it'll be cheaper than what we do right now.
>
> IOW, how about the following (completely untested):
>

I tested the patch against our 3.13 device, and it appears to resolve
the original
write-buffering after sync problem we were having.  I did not do any
other regression
testing, though.

Jeff
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/