linux-kernel - Re: [PATCH] tty: serial: msm: fix checkpatch warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 4 Aug 2014 14:48:23 -0700
From:	Greg KH <gregkh@...uxfoundation.org>
To:	Frank Rowand <frowand.list@...il.com>
Cc:	Kiran Padwal <kiran.padwal@...rtplayin.com>, davidb@...eaurora.org,
	dwalker@...o99.com, bryanh@...eaurora.org, sboyd@...eaurora.org,
	jslaby@...e.cz, linux-arm-msm@...r.kernel.org,
	linux-serial@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] tty: serial: msm: fix checkpatch warnings

On Mon, Aug 04, 2014 at 02:42:02PM -0700, Frank Rowand wrote:
> On 8/4/2014 7:20 AM, Kiran Padwal wrote:
> > This patch fixes the following checkpatch.pl warning:
> > 
> > WARNING: braces {} are not necessary for any arm of this statement
> > 
> > WARNING: Missing a blank line after declarations
> > 
> > WARNING: Prefer [subsystem eg: netdev]_err([subsystem]dev, ... then dev_err(dev, ... then pr_err(...  to printk(KERN_ERR ...
> > 
> > WARNING: Prefer [subsystem eg: netdev]_info([subsystem]dev, ... then dev_info(dev, ... then pr_info(...  to printk(KERN_INFO ...
> > 
> > WARNING: else is not generally useful after a break or return
> > 
> > WARNING: void function return statements are not generally useful
> > 
> > Signed-off-by: Kiran Padwal <kiran.padwal@...rtplayin.com>
> > ---
> >  drivers/tty/serial/msm_serial.c |   26 +++++++++++---------------
> >  1 file changed, 11 insertions(+), 15 deletions(-)
> 
> Kiran,
> 
> I have a series of fix patches against this file that is going to collide
> with your cleanups.  Would you mind waiting until after I send my patches
> to do your clean up?

It's a first-come-first served, never ask someone to wait for you to
send your patches, you can't 'lock' a file in the kernel from changes
from others, that way is the death of a project.

So no, Kiran, don't wait :)

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/