linux-kernel - Re: [PATCH] x86/efi: Fix 3DNow optimization build failure in EFI stub

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 04 Aug 2014 16:06:01 -0700
From:	"H. Peter Anvin" <hpa@...or.com>
To:	Matt Fleming <matt@...sole-pimps.org>
CC:	Ingo Molnar <mingo@...nel.org>, linux-efi@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	Matt Fleming <matt.fleming@...el.com>,
	Borislav Petkov <bp@...e.de>,
	Thomas Gleixner <tglx@...utronix.de>
Subject: Re: [PATCH] x86/efi: Fix 3DNow optimization build failure in EFI
 stub

On 08/04/2014 03:52 PM, Matt Fleming wrote:
> 
> diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig
> index 801ed36c2e49..fcad2e15e92a 100644
> --- a/arch/x86/Kconfig
> +++ b/arch/x86/Kconfig
> @@ -1520,7 +1520,7 @@ config X86_SMAP
>  
>  config EFI
>  	bool "EFI runtime service support"
> -	depends on ACPI
> +	depends on ACPI && !X86_USE_3DNOW
>  	select UCS2_STRING
>  	select EFI_RUNTIME_WRAPPERS
>  	---help---
> 

As we discussed over IRC, should be EFI_STUB not EFI.  Once that is fixed:

Acked-by: H. Peter Anvin <hpa@...ux.intel.com>

... in case Ingo or Thomas grabs it before I do.

	-hpa

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/