linux-kernel - Re: [PATCH] scripts: sortextable: change type and initialise variable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 05 Aug 2014 18:04:56 +0200
From:	Michal Marek <mmarek@...e.cz>
To:	Klemen Jan Enova <klemen.jan.enova@...il.com>
CC:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] scripts: sortextable: change type and initialise variable

On 2014-07-15 11:12, Klemen Jan Enova wrote:
> Change the type of 'relocs_size' from 'int' to 'Elf32_Word' and 
> initialize it to 0, to fix the "maybe uninitialised variable" compiler 
> warning.

Please include the verbatim warning in the commit message.



> Signed-off-by: Klemen Jan Enova <klemen.jan.enova@...il.com>
> ---
> diff --git a/scripts/sortextable.h b/scripts/sortextable.h
> index 8fac3fd..537858d 100644
> --- a/scripts/sortextable.h
> +++ b/scripts/sortextable.h
> @@ -103,7 +103,7 @@ do_func(Elf_Ehdr *ehdr, char const *const fname, 
> table_sort_

Your mailer corrupted the patch by inserting a line break here.


>          Elf_Sym *sort_needed_sym;
>          Elf_Shdr *sort_needed_sec;
>          Elf_Rel *relocs = NULL;
> -       int relocs_size;
> +       Elf32_Word relocs_size = 0;

... and changed tabs to spaces. Please send the patch to yourself first
and see if it applies with 'git am.'

Michal
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/