[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date: Fri, 8 Aug 2014 09:05:56 +0200
From: Pavel Machek <pavel@....cz>
To: joeyli <jlee@...e.com>
Cc: "Lee, Chun-Yi" <joeyli.kernel@...il.com>,
"Rafael J. Wysocki" <rjw@...ysocki.net>,
Len Brown <len.brown@...el.com>, Takashi Iwai <tiwai@...e.de>,
linux-pm@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] Hibernate: check unsafe page should not in e820
reserved region
Hi!
> > When I wrote that num_physpages check, I should have checked
> > whole e820 table, instead. (If anything at all changed there,
> > "new" kernel is running with wrong e820 info).
> >
> > You seem to be in great position to fix that mistake now...
>
> Hashing e820 is fine, but it can not provide detail information to user/developer when issue
> happened. We only know the e820 table changed but not more information for bug tracking, not
> too many shipping machine have serial console.
I don't see what it has to do with serial console, during relevant
stages of hibernation, normal console should be available.
Anyway, either hash or full comparison is file, whatever is simpler.
Thanks,
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists