[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date: Fri, 8 Aug 2014 09:20:38 +0200
From: Tobias Klauser <tklauser@...tanz.ch>
To: Thierry Reding <thierry.reding@...il.com>
Cc: Gyungoh Yoo <gyungoh@...il.com>, rdunlap@...radead.org,
robh+dt@...nel.org, pawel.moll@....com, mark.rutland@....com,
ijc+devicetree@...lion.org.uk, galak@...eaurora.org,
jg1.han@...sung.com, cooloney@...il.com, plagnioj@...osoft.com,
tomi.valkeinen@...com, grant.likely@...aro.org,
sameo@...ux.intel.com, lee.jones@...aro.org, lgirdwood@...il.com,
broonie@...nel.org, jack.yoo@...worksinc.com,
florian.vaussard@...l.ch, jason@...edaemon.net, andrew@...n.ch,
silvio.fricke@...il.com, linux-doc@...r.kernel.org,
linux-kernel@...r.kernel.org, devicetree@...r.kernel.org,
linux-fbdev@...r.kernel.org
Subject: Re: [PATCH] Adding a support for Skyworks SKY81452
On 2014-08-08 at 09:09:19 +0200, Thierry Reding <thierry.reding@...il.com> wrote:
> On Thu, Aug 07, 2014 at 02:34:39PM +0200, Tobias Klauser wrote:
> > On 2014-08-07 at 10:05:38 +0200, Gyungoh Yoo <gyungoh@...il.com> wrote:
> [...]
> > > +#ifdef CONFIG_OF
> > > +static const struct of_device_id sky81452_of_match[] = {
> > > + {.compatible = "sky,sky81452",},
> > > + { }
> > > +};
> > > +MODULE_DEVICE_TABLE(of, sky81452_of_match);
> > > +#endif
> >
> > The #ifdefery here is not needed since you use of_match_ptr below, whcih
> > will expand to NULL of CONFIG_OF is not set.
>
> On the contrary, that's exactly why the #ifdef is needed here. If you
> don't guard the OF match table here, then of_match_ptr() evaluating to
> NULL will cause the table to become unused and the compiler warning
> about it.
Oops, yes of course. Sorry about that and thanks for your correction.
Tobias
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists