linux-kernel - Re: selinux: fix uninitalised stack variable read in sel_netport

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 08 Aug 2014 09:02:08 -0400
From:	Paul Moore <pmoore@...hat.com>
To:	Dave Jones <davej@...hat.com>
Cc:	Linux Kernel <linux-kernel@...r.kernel.org>, jmorris@...ei.org
Subject: Re: selinux: fix uninitalised stack variable read in sel_netport_init

On Thursday, August 07, 2014 12:38:18 PM Dave Jones wrote:
> After the removal of the avc_add_callback() in commit 615e51fdda6
> ("selinux: reduce the number of calls to synchronize_net() when flushing
> caches"), ret is never set to anything, but we return uninitialized stack
> data on success.
> 
> Given the absense of other failure paths, just explicitly return 0.
> 
> Signed-off-by: Dave Jones <davej@...hat.com>

Thanks for the patch, but another more comprehensive patch (there are similar 
problems in netnode.c and netif.c) was posted earlier this week and reposted 
last night ... although evidently I need to send the patch(es) directly to 
Linus, so you'll likely see another repost in a few moments.

> diff --git a/security/selinux/netport.c b/security/selinux/netport.c
> index 73ac6784d091..3311cc393cb4 100644
> --- a/security/selinux/netport.c
> +++ b/security/selinux/netport.c
> @@ -237,7 +237,6 @@ void sel_netport_flush(void)
>  static __init int sel_netport_init(void)
>  {
>  	int iter;
> -	int ret;
> 
>  	if (!selinux_enabled)
>  		return 0;
> @@ -247,7 +246,7 @@ static __init int sel_netport_init(void)
>  		sel_netport_hash[iter].size = 0;
>  	}
> 
> -	return ret;
> +	return 0;
>  }
> 
>  __initcall(sel_netport_init);

-- 
paul moore
security and virtualization @ redhat

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/