linux-kernel - Re: [PATCH 2/3] crypto: testmgr.c: white space removal on __test

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 11 Aug 2014 09:33:50 +0300
From:	Cristian Stoica <cristian.stoica@...escale.com>
To:	Horia Geantă <horia.geanta@...escale.com>,
	<linux-crypto@...r.kernel.org>
CC:	<herbert@...dor.apana.org.au>, <linux-kernel@...r.kernel.org>,
	<davem@...emloft.net>
Subject: Re: [PATCH 2/3] crypto: testmgr.c: white space removal on __test_skcipher

Hi Horia,

On 10.08.2014 11:57, Horia Geantă wrote:
> On 8/8/2014 2:27 PM, Cristian Stoica wrote:
> Don't add more checkpatch warnings on top of existing ones.

I've weighted all the checkpatch warnings and errors introduced by these
patches and I've found them fair versus Linux coding style guide.

If these are the only barriers to acceptance then I'll consider an
update if Herbert agrees with the patches:

> WARNING: line over 80 characters
> #58: FILE: crypto/testmgr.c:992:
> 
>> +			crypto_ablkcipher_set_flags(tfm, CRYPTO_TFM_REQ_WEAK_KEY);

This line is 82 chars long. I find it slightly more readable than the
alternative[s].

"The limit on the length of lines is 80 columns and this is a strongly
preferred limit [...] unless exceeding 80 columns significantly
increases readability and does not hide information"

Now this is a debate about "slightly" vs "significantly". Have fun.

Cristian S.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/