linux-kernel - Re: [PATCH v2 linux-next] arch/x86/mm: sparse 'tlb_single_page_flush

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 11 Aug 2014 10:24:02 -0700
From:	Dave Hansen <dave.hansen@...ux.intel.com>
To:	Jeremiah Mahler <jmmahler@...il.com>,
	David Rientjes <rientjes@...gle.com>
CC:	Thomas Gleixner <tglx@...utronix.de>,
	Ingo Molnar <mingo@...hat.com>,
	"H. Peter Anvin" <hpa@...or.com>, x86@...nel.org,
	Rik van Riel <riel@...hat.com>, Mel Gorman <mgorman@...e.de>,
	Andrew Morton <akpm@...ux-foundation.org>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 linux-next] arch/x86/mm: sparse 'tlb_single_page_flush_ceiling'
 warning

On 08/09/2014 12:38 AM, Jeremiah Mahler wrote:
> A sparse warning is generated about 'tlb_single_page_flush_ceiling'
> not being declared.
> 
>   arch/x86/mm/tlb.c:177:15: warning: symbol
>   'tlb_single_page_flush_ceiling' was not declared. Should it be static?
> 
> Since it isn't used anywhere outside this file, fix the warning by
> making it static.
> 
> Also, optimize the use of this variable by adding the __read_mostly
> directive.

Looks fine to me.  It's definitely __read_mostly.

Acked-by: Dave Hansen <dave.hansen@...ux.intel.com>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/