linux-kernel - Re: [PATCH] drivers: staging: vt6655: wpactl.h: corrected comment format

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 12 Aug 2014 02:48:22 +0800
From:	Greg KH <gregkh@...uxfoundation.org>
To:	Avinash kumar <avi.kp.137@...il.com>
Cc:	forest@...ttletooquiet.net, devel@...verdev.osuosl.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drivers: staging: vt6655: wpactl.h: corrected comment
 format

On Mon, Aug 11, 2014 at 11:26:32PM +0530, Avinash kumar wrote:
> corrected C99 style comment format related error
> 
> Signed-off-by: Avinash Kumar <avi.kp.137@...il.com>
> ---
>  drivers/staging/vt6655/wpactl.h |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/vt6655/wpactl.h b/drivers/staging/vt6655/wpactl.h
> index f7638ba..2ff42c5 100644
> --- a/drivers/staging/vt6655/wpactl.h
> +++ b/drivers/staging/vt6655/wpactl.h
> @@ -36,7 +36,7 @@
>  
>  /*---------------------  Export Definitions -------------------------*/
>  
> -//WPA related
> +/*WPA related*/

Shouldn't you use 2 extra ' ' characters here?

>  enum wpa_alg { WPA_ALG_NONE, WPA_ALG_WEP, WPA_ALG_TKIP, WPA_ALG_CCMP };
>  enum wpa_cipher { CIPHER_NONE, CIPHER_WEP40, CIPHER_TKIP, CIPHER_CCMP,
> @@ -61,4 +61,4 @@ int wpa_set_wpadev(PSDevice pDevice, int val);
>  int wpa_ioctl(PSDevice pDevice, struct iw_point *p);
>  int wpa_set_keys(PSDevice pDevice, void *ctx, bool fcpfkernel);
>  
> -#endif // __WPACL_H__
> +#endif /* __WPACL_H__*/

And one extra ' ' here, right before the '*/' please.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/