linux-kernel - Re: [PATCH] staging: rtl8192u/ieee80211: Fix sparse ieee80211_debug_init/

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 12 Aug 2014 06:32:06 +0800
From:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:	Jeremiah Mahler <jmmahler@...il.com>
Cc:	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org,
	Teodora Baluta <teobaluta@...il.com>,
	Andrea Merello <andrea.merello@...il.com>,
	Joel Pelaez Jorge <joelpelaez@...il.com>,
	Bob Copeland <me@...copeland.com>,
	Joe Perches <joe@...ches.com>, Arnd Bergmann <arnd@...db.de>,
	Himangi Saraogi <himangi774@...il.com>
Subject: Re: [PATCH] staging: rtl8192u/ieee80211: Fix sparse
 ieee80211_debug_init/_exit not declared warning

On Mon, Aug 11, 2014 at 03:15:54PM -0700, Jeremiah Mahler wrote:
> A sparse warning is generated about 'ieee80211_debug_init' and
> 'ieee80211_debug_exit' not being declared.
> 
>   drivers/staging/rtl8192u/ieee80211/ieee80211_module.c:275:12: warning:
>   symbol 'ieee80211_debug_init' was not declared. Should it be static?
>   drivers/staging/rtl8192u/ieee80211/ieee80211_module.c:297:13: warning:
>   symbol 'ieee80211_debug_exit' was not declared. Should it be static?
> 
> These functions are used outside of this file so using static will not
> work.  Fix the warning by declaring the functions in the header file,
> ieee80211.h
> 
> Signed-off-by: Jeremiah Mahler <jmmahler@...il.com>
> Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> Cc: Teodora Baluta <teobaluta@...il.com>
> Cc: Andrea Merello <andrea.merello@...il.com>
> Cc: Joel Pelaez Jorge <joelpelaez@...il.com>
> Cc: Bob Copeland <me@...copeland.com>
> Cc: Joe Perches <joe@...ches.com>
> Cc: Arnd Bergmann <arnd@...db.de>
> Cc: Himangi Saraogi <himangi774@...il.com>
> ---
>  drivers/staging/rtl8192u/ieee80211/ieee80211.h | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211.h b/drivers/staging/rtl8192u/ieee80211/ieee80211.h
> index 1040bab..9cbda69 100644
> --- a/drivers/staging/rtl8192u/ieee80211/ieee80211.h
> +++ b/drivers/staging/rtl8192u/ieee80211/ieee80211.h
> @@ -2485,6 +2485,12 @@ extern int ieee80211_wx_set_freq(struct ieee80211_device *ieee, struct iw_reques
>  extern int ieee80211_wx_get_freq(struct ieee80211_device *ieee, struct iw_request_info *a,
>  			     union iwreq_data *wrqu, char *b);
>  
> +/* ieee80211_module.c */
> +#ifdef CONFIG_IEEE80211_DEBUG
> +extern int __init ieee80211_debug_init(void);
> +extern void __exit ieee80211_debug_exit(void);
> +#endif /* CONFIG_IEEE80211_DEBUG */
> +

As it's a header file, why not always have them here, no need for the
ifdef.

And __init and __exit don't belong in a .h function prototype.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/