linux-kernel - Re: [PATCH] misc: ti-st: st_kim.c: Cleaning up missing null-terminate after strncpy call

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 10 Aug 2014 18:01:48 -0700
From:	Mark D Rustad <mrustad@...il.com>
To:	Rickard Strandqvist <rickard_strandqvist@...ctrumdigital.se>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Linus Walleij <linus.walleij@...aro.org>,
	Wolfram Sang <wsa@...-dreams.de>,
	Peter Hurley <peter@...leysoftware.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] misc: ti-st: st_kim.c:  Cleaning up missing null-terminate after strncpy call

On Aug 9, 2014, at 4:45 PM, Rickard Strandqvist <rickard_strandqvist@...ctrumdigital.se> wrote:

> Added a guaranteed null-terminate after call to strncpy.
> 
> Signed-off-by: Rickard Strandqvist <rickard_strandqvist@...ctrumdigital.se>
> ---
> drivers/misc/ti-st/st_kim.c |    1 +
> 1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/misc/ti-st/st_kim.c b/drivers/misc/ti-st/st_kim.c
> index 9d3dbb2..bce4468 100644
> --- a/drivers/misc/ti-st/st_kim.c
> +++ b/drivers/misc/ti-st/st_kim.c
> @@ -593,6 +593,7 @@ static ssize_t store_dev_name(struct device *dev,
> 	struct kim_data_s *kim_data = dev_get_drvdata(dev);
> 	pr_debug("storing dev name >%s<", buf);
> 	strncpy(kim_data->dev_name, buf, count);
> +	kim_data->dev_name[count - 1] = '\n';

Of course this does not add termination, but adds a newline at the end of the buffer? Huh?

> 	pr_debug("stored dev name >%s<", kim_data->dev_name);
> 	return count;
> }

-- 
Mark Rustad, MRustad@...il.com


Download attachment "signature.asc" of type "application/pgp-signature" (842 bytes)